xwiki-devs

xwiki-devs@xwiki.org

9400 discussions

[xwiki-devs] filtering by com.xpn.xwiki.objects.LargeStringProperty properties values

by [Ricardo Rodriguez] eBioTIC.

Hi! Caleb and I have been chatting this afternoon about a solution to pass the value of a variable to a query string. Thanks Caleb! Something like this... ##$species is defined simply by... #set($species = '%babo%') ##and the query string is constructed by using + to concatenate stubs including the value of that variable... #set($query = ", BaseObject as obj, StringProperty as prop where doc.fullName = obj.name and obj.className='Users.PdrUserClass' and obj.id=prop.id.id and prop.id.name='Species' and prop.value like '" + $species + "' order by doc.fullName asc") This works great with com.xpn.xwiki.objects.StringProperty properties, but not with com.xpn.xwiki.objects.StringProperty ones. Please, do you know why and what is required to filter by properties of that type? Thanks! Ricardo -- Ricardo Rodríguez CTO eBioTIC. Life Sciences, Data Modeling and Information Management Systems

14 years, 4 months

Re: [xwiki-devs] [xwiki-notifications] r31359 - enterprise/trunk/wiki/src/main/resources/Main

by Thomas Mortagne

On Sat, Sep 25, 2010 at 14:50, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote: > On Sat, Sep 25, 2010 at 14:44, sdumitriu > <enterprise-notifications(a)xwiki.org> wrote: >> Author: sdumitriu >> Date: 2010-09-25 14:44:23 +0200 (Sat, 25 Sep 2010) >> New Revision: 31359 >> >> Modified: >> enterprise/trunk/wiki/src/main/resources/Main/Spaces.xml >> Log: >> XE-542: Apache proxy breaks icons on the Dashboard. >> Fixed. >> >> Modified: enterprise/trunk/wiki/src/main/resources/Main/Spaces.xml >> =================================================================== >> --- enterprise/trunk/wiki/src/main/resources/Main/Spaces.xml 2010-09-25 09:59:48 UTC (rev 31358) >> +++ enterprise/trunk/wiki/src/main/resources/Main/Spaces.xml 2010-09-25 12:44:23 UTC (rev 31359) >> @@ -191,16 +191,16 @@ >> <div class="spSpaceName">[[${space}>>${space}.WebHome]]</div> >> <div class="xshowonhover spSpaceActions"> >> ## Link to the space index. >> - <a href="$xwiki.getURL('Main.SpaceIndex', 'view', "space=$escapetool.url($space)")" title="$msg.get('xe.spaces.action.index')"> >> - <img src="$xwiki.getSkinFile('icons/silk/book_open.gif')" alt="$msg.get('xe.spaces.action.index.alt')"/> >> + <a href="{{html wiki="false"}}$xwiki.getURL('Main.SpaceIndex', 'view', "space=$escapetool.url($space)"){{/html}}" title="$msg.get('xe.spaces.action.index')"> > > Note that wiki=false is alre (sorry, Gmail shortcuts) Note that wiki=false is already the default > >> + <img src="{{html wiki="false"}}$xwiki.getSkinFile('icons/silk/book_open.gif'){{/html}}" alt="$msg.get('xe.spaces.action.index.alt')"/> >> </a> >> ## If the user has admin right on the space display links to administration and delete. >> #if($xwiki.hasAccessLevel('admin', "${space}.XWikiPreferences")) >> - <a href="$xwiki.getURL("${space}.WebPreferences", 'admin')" title="$msg.get('xe.spaces.action.admin')"> >> - <img src="$xwiki.getSkinFile('icons/silk/cog.gif')" alt="$msg.get('xe.spaces.action.admin.alt')"/> >> + <a href="{{html wiki="false"}}$xwiki.getURL("${space}.WebPreferences", 'admin'){{/html}}" title="$msg.get('xe.spaces.action.admin')"> >> + <img src="{{html wiki="false"}}$xwiki.getSkinFile('icons/silk/cog.gif'){{/html}}" alt="$msg.get('xe.spaces.action.admin.alt')"/> >> </a> >> - ## <a href="#" onclick="confirm('ALL THE PAGES WITHIN THE SPACE &ldquo;${space}&rdquo; WILL BE DELETED, are you sure that you want to continue ?'); this.href='$spaceListDoc.getURL('view', "deleteSpace=${space}&amp;xredirect=$doc.getExternalURL()&amp;form_token=$!{services.csrf.getToken()}")'" title="$msg.get('xe.spaces.action.delete')"> >> - ## <img src="$xwiki.getSkinFile('icons/silk/cross.gif')" alt="$msg.get('xe.spaces.action.delete.alt')" /> >> + ## <a href="#" onclick="confirm('ALL THE PAGES WITHIN THE SPACE &ldquo;${space}&rdquo; WILL BE DELETED, are you sure that you want to continue ?'); this.href='{{html wiki="false"}}$spaceListDoc.getURL('view', "deleteSpace=${space}&amp;xredirect=$doc.getExternalURL()&amp;form_token=$!{services.csrf.getToken()}"){{/html}}'" title="$msg.get('xe.spaces.action.delete')"> >> + ## <img src="{{html wiki="false"}}$xwiki.getSkinFile('icons/silk/cross.gif'){{/html}}" alt="$msg.get('xe.spaces.action.delete.alt')" /> >> ## </a> >> #end >> </div> >> @@ -215,10 +215,10 @@ >> #if($xwiki.hasAdminRights()) >> <li id="spSpaceCreateItem" class="xitem space"> >> <div class="xitemcontainer"> >> - <div id="spSpaceCreateLabel" class="spSpaceName"><a href="$xwiki.getURL('XWiki.CreatePage', 'view', 'tocreate=space')" onclick="toggleClass($('spSpaceCreateForm'), 'hidden'); return false;">$msg.get('xe.spaces.createspace')</a></div> >> + <div id="spSpaceCreateLabel" class="spSpaceName"><a href="{{html wiki="false"}}$xwiki.getURL('XWiki.CreatePage', 'view', 'tocreate=space'){{/html}}" onclick="toggleClass($('spSpaceCreateForm'), 'hidden'); return false;">$msg.get('xe.spaces.createspace')</a></div> >> <div class="spacer">&nbsp;</div> >> <div id="spSpaceCreateForm" class="hidden"> >> - <form method="post" action="$doc.getURL('view', 'xpage=create')"> >> + <form method="post" action="{{html wiki="false"}}$doc.getURL('view', 'xpage=create'){{/html}}"> >> <div> >> <input name="tocreate" type="hidden" value="space" /> >> #set($newSpaceName = $escapetool.xml($msg.get('xe.spaces.createspace.defaultname'))) >> >> _______________________________________________ >> notifications mailing list >> notifications(a)xwiki.org >> http://lists.xwiki.org/mailman/listinfo/notifications >> > > > > -- > Thomas Mortagne > -- Thomas Mortagne

14 years, 4 months

[xwiki-devs] Issue with DBList cache

by Ludovic Dubost

Hi, I've reported bug http://jira.xwiki.org/jira/browse/XWIKI-5525. In my view we should cancel the patch from http://jira.xwiki.org/jira/browse/XWIKI-1725. The context level cache has been made ineffective. This has an impact on LiveTable speeds in particular. Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

14 years, 4 months

[xwiki-devs] [ANN] XWiki Enterprise and XWiki Enterprise Manager 2.4.2 Released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise and XWiki Enterprise Manager 2.4.2. It fixes a critical issue in some applications that fail with the following error: Can't find descriptor for the component xwiki.script.service.Script Service? hint = csrf?] For more information see the Releases notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise242 and http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXEM242 Thanks -The XWiki dev team

14 years, 4 months

[xwiki-devs] [ANN] XWiki Enterprise and XWiki Enterprise Manager 2.4.1 Released

by Thomas Mortagne

The XWiki development team is pleased to announce the release of XWiki Enterprise and XWiki Enterprise Manager 2.4.1. This is a bug fix release for the 2.4 branch. Important Bugs fixed: * XWIKI-5511 - In some conditions a newly created wiki does not have the standard classes * XWIKI-5492 - Can't move the focus outside of the rich text area in Opera * XWIKI-5440 - user.isUserInGroup return false if User in Master and group in virtual * XWIKI-5452 - "cache.path" configuration is not taken into account by JBossCache module * XWIKI-5414 - Keyboard shortcuts are not ignored when trying to navigate with keys in a select input * XWIKI-5391 - MediaWikiScanner#docElements() raises unexpected ParseException when encountering <D_TABLE_CAPTION> tokens * XWIKI-5515 - NPE when accessing an not existing wiki and autowww = 0 * XWIKI-5363 - PeriodFactory#createSinceMonthsPeriod creates a "since weeks" period instead * XWIKI-5476 - Problem with non-px image dimensions in wysiwyg mode only with IE7 * XWIKI-5457 - Propeditor cannot work anymore with recent livetable code * XWIKI-5243 - Reflected XSS in edit(wiki|wysiwyg|wysiwygnew).vm * XWIKI-5450 - SQL injection in suggest.vm * XWIKI-5428 - Save and Continue doesn't validate the mandatory document title * XWIKI-5434 - Saved request parameters are not restored on relogin * XWIKI-5244 - Stored XSS via user/group name * XWIKI-5510 - Text and background color don't match the color themev * XWIKI-5417 - xwiki/2.0 renderer should escape any (% it can find * XWIKI-5453 - includeMacro() no longer works in XE 2.4 * XASEARCH-10 - Escaping issue in Main.DatabaseSearch * XAADMINISTRATION-156 - Cannot add "global" user in groups * XAADMINISTRATION-155 - Improper search icon position in Administration Application * XAADMINISTRATION-168 - Small inconsistency in DOM of some elements that use ConfigurationClass Class For more information see the Releases notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise241 and http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXEM241 Thanks -The XWiki dev team

14 years, 4 months

[xwiki-devs] [Vote] Resize images on the server side to reduce page loading time

by Marius Dumitru Florea

Hi devs, Currently the image plugin [1] allows us to create image thumbnails by specifying the image width and/or height in the query string of the image attachment download URL: /xwiki/bin/download/Spage/Page/image.jpg?width=100 I propose that we: (A) Use the image width and/or height (when they are specified in the image syntax using pixel unit) to resize the image on the server side. For instance: [[image:logo.jpg||width="100px"]] will be linked to /xwiki/bin/download/Spage/Page/logo.jpg?width=100 and [[image:logo.jpg||style="height: 50px; width: 70px"]] will be linked to /xwiki/bin/download/Spage/Page/logo.jpg?width=70&height=50 The image plugin also accepts a quality parameter that controls the compression quality when encoding jpeg images. The default value of this parameter (i.e. when not specified in the URL) is configurable. I propose we use 0.3 by default, 1 representing the best quality. (B) Add the ability to limit the image dimensions (preserving aspect ratio) when the image width and/or height are not specified in the image syntax (or when they are not using pixel unit). The width and height limit will be configurable and -1 by default (i.e. no limitation). For instance: image:logo.jpg will be linked to /xwiki/bin/download/Spage/Page/logo.jpg?width=1024 when width limit is 1024, and to /xwiki/bin/download/Spage/Page/logo.jpg?width=1024&height=768&keepAspectRatio=true when width limit is 1024 and height limit is 768. Note that in this case the image aspect ratio is preserved. The image is resized to best fit the limits. If the user want to bypass the limit he has to specify the image width/height in the image syntax. I'm +1 for both (A) and (B). WDYT? Thanks, Marius [1] http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk/xwiki-core/src/main/…

14 years, 4 months

[xwiki-devs] Extend model service with methods for creating and resolving attachment references

by Marius Dumitru Florea

Hi devs, I created http://jira.xwiki.org/jira/browse/XWIKI-5519 and attached a patch. I'd like to commit this before 2.5M2. Let me know if you don't agree. Thanks, Marius

14 years, 4 months

Re: [xwiki-devs] [xwiki-notifications] r31271 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web

by Vincent Massol

Hi Alex, Couldn't we add the check in some Abstract<XXX>XWikiAction where <XXX> qualifies actions that modify data in order to prevent code duplication and in order to prevent forgetting to do the check when people add new actions (at least make it easier)? Thanks -Vincent On Sep 22, 2010, at 11:00 PM, abusenius (SVN) wrote: > Author: abusenius > Date: 2010-09-22 23:00:46 +0200 (Wed, 22 Sep 2010) > New Revision: 31271 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/AbstractPropChangeAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/CommentAddAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAttachmentAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectAddAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropAddAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropUpdateAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RegisterAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ResetVersionsAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RollbackAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UndeleteAction.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UploadAction.java > Log: > XWIKI-5464: Added CSRF checks to all actions that modify data > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/AbstractPropChangeAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/AbstractPropChangeAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/AbstractPropChangeAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -55,6 +55,10 @@ > BaseClass xclass = doc.getXClass(); > > if (propertyName != null && xclass.get(propertyName) != null) { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > changePropertyDefinition(xclass, propertyName, context); > } else { > return true; > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/CommentAddAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/CommentAddAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/CommentAddAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -54,6 +54,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiResponse response = context.getResponse(); > XWikiDocument doc = context.getDoc(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -55,6 +55,10 @@ > if (!"1".equals(request.getParameter(CONFIRM_PARAM))) { > return true; > } > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > > String sindex = request.getParameter("id"); > if (sindex != null && xwiki.hasRecycleBin(context)) { > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAttachmentAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAttachmentAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteAttachmentAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -46,6 +46,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWikiRequest request = context.getRequest(); > XWikiResponse response = context.getResponse(); > XWikiDocument doc = context.getDoc(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/DeleteVersionsAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -40,21 +40,24 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > DeleteVersionsForm form = (DeleteVersionsForm) context.getForm(); > - > if (!form.isConfirmed()) { > return true; > } > > Version v1; > Version v2; > - Version rev = form.getRev(); > - if (rev == null) { > + if (form.getRev() == null) { > v1 = form.getRev1(); > v2 = form.getRev2(); > } else { > - v1 = rev; > - v2 = rev; > + v1 = form.getRev(); > + v2 = form.getRev(); > } > > if (v1 != null && v2 != null) { > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectAddAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectAddAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectAddAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -39,6 +39,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiResponse response = context.getResponse(); > String username = context.getUser(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -66,6 +66,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiResponse response = context.getResponse(); > String username = context.getUser(); > @@ -74,6 +79,7 @@ > if (obj == null) { > return true; > } > + > doc.removeObject(obj); > doc.setAuthor(username); > xwiki.saveDocument(doc, context.getMessageTool().get("core.comment.deleteObject"), true, context); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropAddAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropAddAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropAddAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -37,6 +37,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiResponse response = context.getResponse(); > XWikiDocument doc = context.getDoc(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropUpdateAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropUpdateAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/PropUpdateAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -105,6 +105,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > try { > if (propUpdate(context)) { > return true; > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RegisterAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RegisterAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RegisterAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -50,6 +50,11 @@ > > String register = request.getParameter(REGISTER); > if (register != null && register.equals("1")) { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > int useemail = xwiki.getXWikiPreferenceAsInt("use_email_verification", 0, context); > int result; > if (useemail == 1) { > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ResetVersionsAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ResetVersionsAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/ResetVersionsAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -17,6 +17,11 @@ > > String confirm = request.getParameter("confirm"); > if ((confirm != null) && (confirm.equals("1"))) { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWikiDocument tdoc = getTranslatedDocument(doc, language, context); > // Do it > tdoc.resetArchive(context); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RollbackAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RollbackAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/RollbackAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -30,6 +30,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiResponse response = context.getResponse(); > XWikiDocument doc = context.getDoc(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -176,6 +176,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > if (save(context)) { > return true; > } > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -43,6 +43,11 @@ > */ > @Override > public boolean action(XWikiContext context) throws XWikiException { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > // Try to find the URL of the edit page which we came from > String back = findBackURL(context); > > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UndeleteAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UndeleteAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UndeleteAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -42,6 +42,11 @@ > @Override > public boolean action(XWikiContext context) throws XWikiException > { > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWiki xwiki = context.getWiki(); > XWikiRequest request = context.getRequest(); > XWikiResponse response = context.getResponse(); > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UploadAction.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UploadAction.java 2010-09-22 21:00:42 UTC (rev 31270) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UploadAction.java 2010-09-22 21:00:46 UTC (rev 31271) > @@ -80,6 +80,11 @@ > } > } > > + // CSRF prevention > + if (!csrfTokenCheck(context)) { > + return false; > + } > + > XWikiDocument doc = (XWikiDocument) context.getDoc().clone(); > > // The document is saved for each attachment in the group.

14 years, 4 months

by Sergiu Dumitriu

On 09/23/2010 12:23 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2010-09-23 12:23:25 +0200 (Thu, 23 Sep 2010) > New Revision: 31277 You should have used a serverside move instead of a local copy, since the sandbox history is now lost. > Added: > platform/core/trunk/xwiki-extension/ > platform/core/trunk/xwiki-extension/pom.xml > platform/core/trunk/xwiki-extension/src/ > platform/core/trunk/xwiki-extension/src/main/ > platform/core/trunk/xwiki-extension/src/main/java/ > platform/core/trunk/xwiki-extension/src/main/java/org/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/CoreExtension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/Extension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ExtensionDependency.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ExtensionException.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ExtensionId.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ExtensionManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ExtensionManagerConfiguration.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/InstallException.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/LocalExtension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/ResolveException.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/UninstallException.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/ExtensionHandler.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/ExtensionHandlerManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/AbstractExtensionHandler.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/DefaultExtensionHandlerManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/DefaultJarExtensionClassLoader.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/JarExtensionClassLoader.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/JarExtensionExecutionContextInitializer.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/JarExtensionHandler.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/install/internal/jar/JarHandlerApplicationStartedListener.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/DefaultExtensionManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/DefaultExtensionManagerConfiguration.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/DefaultVersionManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/VersionManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/script/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/internal/script/ExtensionManagerScriptService.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/CoreExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepositoryException.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepositoryFactory.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepositoryId.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepositoryManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/ExtensionRepositorySource.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/LocalExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/ConfigurationExtensionRepositorySource.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/DefaultCoreExtension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/DefaultCoreExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/DefaultExtensionRepositoryManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/DefaultLocalExtension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/DefaultLocalExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/LocalExtensionDependency.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/AetherExtension.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/AetherExtensionDependency.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/AetherExtensionRepository.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/AetherExtensionRepositoryFactory.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/XWikiLogger.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/XWikiLoggerManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/configuration/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/configuration/AetherConfiguration.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/aether/configuration/DefaultAetherConfiguration.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/plexus/ > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/plexus/DefaultPlexusComponentManager.java > platform/core/trunk/xwiki-extension/src/main/java/org/xwiki/extension/repository/internal/plexus/PlexusComponentManager.java > platform/core/trunk/xwiki-extension/src/main/resources/ > platform/core/trunk/xwiki-extension/src/main/resources/META-INF/ > platform/core/trunk/xwiki-extension/src/main/resources/META-INF/components.txt > platform/core/trunk/xwiki-extension/src/test/ > platform/core/trunk/xwiki-extension/src/test/java/ > platform/core/trunk/xwiki-extension/src/test/java/org/ > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/ > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/ > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/repository/ > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/repository/AetherDefaultRepositoryManagerTest.java > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/repository/DefaultCoreExtensionRepositoryTest.java > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/repository/DefaultExtensionManagerTest.java > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/repository/DefaultLocalExtensionRepositoryTest.java > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/test/ > platform/core/trunk/xwiki-extension/src/test/java/org/xwiki/extension/test/ConfigurableDefaultCoreExtensionRepository.java > platform/core/trunk/xwiki-extension/src/test/resources/ > platform/core/trunk/xwiki-extension/src/test/resources/localextensions/ > platform/core/trunk/xwiki-extension/src/test/resources/localextensions/existingextension-version.type > platform/core/trunk/xwiki-extension/src/test/resources/localextensions/existingextension-version.xed > platform/core/trunk/xwiki-extension/src/test/resources/localextensions/existingextensiondependency-version.type > platform/core/trunk/xwiki-extension/src/test/resources/localextensions/existingextensiondependency-version.xed > platform/xwiki-applications/trunk/extension/ > platform/xwiki-applications/trunk/extension/pom.xml > platform/xwiki-applications/trunk/extension/src/ > platform/xwiki-applications/trunk/extension/src/main/ > platform/xwiki-applications/trunk/extension/src/main/resources/ > platform/xwiki-applications/trunk/extension/src/main/resources/ExtensionManager/ > platform/xwiki-applications/trunk/extension/src/main/resources/ExtensionManager/WebHome.xml > Modified: > enterprise/trunk/pom.xml > platform/core/trunk/pom.xml > platform/web/trunk/standard/pom.xml > platform/xwiki-applications/trunk/pom.xml > platform/xwiki-tools/trunk/xem-web-debug-eclipse/pom.xml > Log: > XWIKI-5518: Introduce Extension Manager -- Sergiu Dumitriu http://purl.org/net/sergiu/

14 years, 4 months

[xwiki-devs] [proposal] Make form generation/validation code a top level application.

by Caleb James DeLisle

Hi, I have started creating the classes for representing forms, form fields and form field validation constraints. I now have: FormTextAreaFieldClass FormSelectFieldClass FormTextFieldClass FormFieldConstraintClass and I plan to add: FormClass and FormGenerator Since there seem to be a lot of documents associated with this project, I am proposing to make it a top level application and put the documents in a new space called Forms. WDYT?

14 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs