xwiki-devs

xwiki-devs@xwiki.org

9400 discussions

[xwiki-devs] [VOTE] Add Ecaterina Valica as a committer

by Sergiu Dumitriu

Hi devs, I'd like to propose Ecaterina Valica as a committer on XE, skins and applications. Ecaterina has been doing a good job moving XWiki towards better and more consistent UIs. I've been applying her patches for the last months, and lately I believe that the quality is good, and they do not need major changes anymore. This would really speed up resolving skin issues and improvements. Here's my +1. Disclaimer: Ecaterina is working for XWiki SAS. For more details on the XWiki project and XWiki SAS see http://massol.myxwiki.org/xwiki/bin/view/Blog/XWikiSASAndOpenSource -- Sergiu Dumitriu http://purl.org/net/sergiu/

15 years

Re: [xwiki-devs] [xwiki-notifications] r26278 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects

by Thomas Mortagne

On Thu, Jan 21, 2010 at 14:25, vmassol <platform-notifications(a)xwiki.org> wrote: > Author: vmassol > Date: 2010-01-21 14:25:39 +0100 (Thu, 21 Jan 2010) > New Revision: 26278 > > Modified: > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseElement.java > Log: > XWIKI-4753: Refactor old model to use the new Entity Reference classes > > * Removed warning since there are too many left and this causes functional test errors (false positives) > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseElement.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseElement.java 2010-01-21 11:10:10 UTC (rev 26277) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/BaseElement.java 2010-01-21 13:25:39 UTC (rev 26278) > @@ -127,11 +127,7 @@ > { > // If the name is already set then reset it since we're now using a reference > this.reference = reference; > - if (this.name != null) { > - LOG.warn("Element was stored as name [" + this.name + "]. Will now be stored as a reference [" > - + reference + "]"); > - this.name = null; > - } > + this.name = null; You could keep a debug log. Someone could enable debug log to track wrong uses. > } > > /** > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

15 years

[xwiki-devs] [proposal][discussion]Object properties references

by Anca Luca

Hi devs, Short story: 1/ add the CLASS, OBJECT, PROPERTY EntityTypes in the model +1 2/ serialization for referencing a property of an object a) wiki:Space.Page^className[objectNumber]#property b) wiki:Space.Page^className#objectNumber$property +0.75 for b) Long story: 1/ I would need to extend the EntityReference to be able to target a property in an object in a document. For this, I will need to add /** * Represents a Class Entity */ CLASS, /** * Represents an Object Entity. */ OBJECT, /** * Represents a Property Entity */ PROPERTY, in the EntityType. Although I would prefer an extensible framework that would allow to extend the possible entity types without changing an enum in the platform (for any API user to be able to define its own references), I think this is fairly extensible (these are key concepts in the xwiki model and I don't think they would be changed that soon, and their interpretation is flexible, they could be combined with any parent to generate either references to class definitions or instances). here's my +1 for this. 2/ I would also need a 'standard' string serialization for these. Now, there's also the option to do it in my own module (annotations) because only I need it ftm, but I prefer to have a platform wide approach. Opinions? There are 2 choices, with a potentially different combination of separators: a/ wiki:Space.Page^className[objectNumber]#property pros: it's a suggestive way to access objects by number ([] is the standard syntax for array indexed access and the objects are accessed by index), [] is supported by JCR so maybe we should support it too cons: [] is somewhat inconsistent with all other separators which are just one separator, to the left (right) of the entity, harder to implement the [] separators on the current framework b/ wiki:Space.Page^className#objectNumber$property pros: inline with the separator usage we already have (and easier to implement for this reason), could be easier refactored to contain an object name instead of the number cons: $ separator can collide with velocity syntax (can potentially cause trouble when used in velocity -- an alternative could be the pipe |), could be harder to drop the object number part of the reference to refer a property in a class (if wanted, in the future) I have no other argument between a) and b) but the implementation speed one, so I'd go for a b)-like approach, in the spirit of the current separators. WDYT? Thanks, Anca

15 years

Re: [xwiki-devs] [xwiki-notifications] r26234 - enterprise/trunk/wiki/src/main/resources/Main platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki platform/core/trunk/xwiki-core/src/main/resources platform/skins/trunk/colibri/src/main/resources/colibri platform/web/trunk/standard/src/main/webapp/templates platform/xwiki-applications/trunk/administration/src/main/resources/XWiki

by Jerome Velociter

jvdrean (SVN) wrote: > Author: jvdrean > Date: 2010-01-19 16:37:08 +0100 (Tue, 19 Jan 2010) > New Revision: 26234 > > Added: > platform/skins/trunk/colibri/src/main/resources/colibri/noavatar.png > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/XWikiUserPreferencesSheet.xml > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/XWikiUserProfileSheet.xml > Modified: > enterprise/trunk/wiki/src/main/resources/Main/Dashboard.xml > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > platform/core/trunk/xwiki-core/src/main/resources/ApplicationResources.properties > platform/skins/trunk/colibri/src/main/resources/colibri/changemyavatar.vm > platform/skins/trunk/colibri/src/main/resources/colibri/colibri.css > platform/skins/trunk/colibri/src/main/resources/colibri/passwd.vm > platform/web/trunk/standard/src/main/webapp/templates/changemyavatar.vm > platform/web/trunk/standard/src/main/webapp/templates/passwd.vm > platform/xwiki-applications/trunk/administration/src/main/resources/XWiki/XWikiUserSheet.xml > Log: > XE-466 : User Profile UI Improvements > XSCOLIBRI-178 : User Profile UI Improvements > XWIKI-4767 : Add phone fields to the user profile > [snip] > +<code>Object.extend(XWiki, { > + userprofile : { > + > + init : function() { > + Event.observe($('avatar'), 'mouseover', XWiki.userprofile.toggleChangePhoto); > + Event.observe($('avatar'), 'mouseout', XWiki.userprofile.toggleChangePhoto); > + }, > + > + toggleChangePhoto : function() { > + var changePhoto = $('avatarUpload'); > + if (eltHasClass(changePhoto, 'hidden')) { > + var photoCoords = Element.positionedOffset($('avatar')); > + changePhoto.style.left = photoCoords[0] + "px"; > + changePhoto.style.top = photoCoords[1] + "px"; > + rmClass(changePhoto, 'hidden'); > + } else { > + addClass(changePhoto, 'hidden'); > + } > + }, We should not use eltHasClass, rmClass and addClass any more but Element#hasClassName Element#removeClassName and Element#addClassName from prototype instead. > + > + switchTab : function(tab) { > + $("vertical-panes").select("div.vertical-pane").each(function(pane){ > + if(!eltHasClass(pane,'hidden')) { > + addClass(pane, 'hidden'); > + } > + }); > + rmClass($(tab + 'Pane'), 'hidden'); > + $("vertical-tabs").select("li.vertical-tab").each(function(tab){ > + if(eltHasClass(tab, 'active')) { > + rmClass(tab, 'active'); > + } > + }); > + addClass($(tab + 'Tab'), 'active'); > + } > + } > +}); > + > +Event.observe(window, 'load', function() { XWiki.userprofile.init() }) Here you can probably observe dom loading instead of window load. [snip] > +/* Tabs */ > + > +div#vertical-panes { > + margin-top: 10px; > +} Can't the vertical panes system be independent of an ID ? (to allow several by page) Shouldn't those styles be separated from the user profile? Jerome. > + > +div#avatar { > + float: left; > + margin-right:10px; > +} > + > +span#avatarUpload { > + display:block; > + width:$tabswidth; > + position:absolute; > + font-size: 10px; > + font-weight: bold; > + background-color: white; > +} > + > +#vertical-tabs { > + float:left; > + width:$tabswidth; > +} > + > +#vertical-tabs ul { > + margin:0; > + margin-top:5px; > + padding:0; > + border-right:0; > + border-bottom:0; > + border-left:0; > +} > + > +#vertical-tabs ul li { > + display: block; > + list-style-type: none; > + margin:0; > + border: solid 1px transparent; > + border-right: 0; > +} > + > +#vertical-tabs ul li img { > + float:left; > + margin-right:4px; > + vertical-align:middle; > +} > + > +#vertical-tabs ul li span { > + line-height:1.5em; > +} > + > +#vertical-tabs ul li.active { > + border: solid 1px $theme.menuBackgroundColor; > + border-right: 0; > +} > + > +#vertical-tabs ul li a { > + padding: 3px 10px 3px 10px; > + text-decoration: none; > + display:block; > + color:$theme.menuBackgroundColor; > +} > + > +#vertical-tabs ul li.active a { > + text-decoration: none; > + left:1px; > + background:$theme.pageContentBackgroundColor; > + position:relative; > + color: $theme.textColor; > + padding-left: 9px; > +} > + > +.vertical-pane { > + margin-left:$tabswidth; > + border-left: solid 1px $theme.menuBackgroundColor; > + padding: 10px; > + padding-top: 0; > +} > +</code> [snip]

15 years

[xwiki-devs] User profile - Need free form area

by Vincent Massol

Hi guys, I think we need a free form area in the user profile where the user can put whatever he wants and that would be displayed below the current grey box (containing personal info + contact + external links). Users often want to add content to their home page. The About field isn't appropriate for this (it could be left as is though). WDYT? Thanks -Vincent

15 years

Re: [xwiki-devs] Problem of Load GWT Application in Edit Panel

by Leon Wang

Hi Everyone, Hi Marius, "What version of XWiki Enterprise do you use? Looks like an URL is badly parsed. There shouldn't be any "xwiki:resources.js" page. There's no resources.js file for sure in the default distribution." I am using xwiki-enterprise-web-2.1.1, I downloaded the war file, xwiki-enterprise-web-2.1.1.war, from xwiki website. "Two questions: (1) do you get the same velocity exception when viewing the Panels.YourPanelName page? (2) When you get the velocity exception, is your JavaScript file loaded properly? Check with firebug in the header of the edited page for the associated script tag." (1). Yes, I get exception when viewing the Panels. Here is visual: http://picasaweb.google.com/lh/photo/0ZTNIoSvoAWZe9NveH_3SA?feat=directlink (2). Here is the pic, I do not think they are loaded right. http://picasaweb.google.com/lh/photo/U826Ehn6oVWcxiGoUZBsrA?feat=directlin “An advice: don't leave useless empty lines in the panel content because they generate paragraphs.” I took your advice, but it is still not work. Another example is Design Rationale Type Tree (http://picasaweb.google.com/lh/photo/lS-61ZTSh2kbKpl3JiQqSQ?feat=directlink) I can load it now. In the pass it will give me the same error above. No matter under \xwiki-web or under \xwiki-web\wysiwyg, when I use mvn install or mvn gwt:debug, it will report Unable to find resource 'velocity-tools:velocity-tools:pom:1.4' http://picasaweb.google.com/lh/photo/QxRZUSeo1rdpV7UYC2sIqg?feat=directlink Thank you everyone! Sincerely. Leon

15 years

Re: [xwiki-devs] A Question

by Marius Dumitru Florea

Leon Wang wrote: > Hi Marius, > > I asked a question no one answer me. Could you please give me some idea? Someone did answer, asking for more information http://lists.xwiki.org/pipermail/devs/2010-January/016890.html > When I use "mvn install" or "mvn gwt:debug" it will report could not Use where? In which maven project/module? > find velocity-tools:velocity-tools:pom:1.4 file: > [INFO] Downloading: > http://maven.xwiki.org/externals/velocity-tools/velocity-tools/1.4/velocity… [INFO] > Unable to find resource 'velocity-tools:velocity-tools:pom:1.4' in > repository xwiki-externals > (http://maven.xwiki.org/externals) Downloading: > http://maven.xwiki.org/releases/velocity-tools/velocity-tools/1.4/velocity-… Does the build fail? There's nothing wrong with the report above. > > When I try to load my GWT application at the edit panel, and at the edit > model firebug will give me velocity parsing error.What should I do? Here > is the error: Firebug reports client side exceptions (mainly JavaScript) while velocity exceptions happen on the server side. I don't see the relation between firebug and the velocity exception you pasted below. > <a href="" onclick="document.getElementById('xwikierror1').style.display='block'; return false;">Error number 4001 in 4: Error while parsing velocity page xwiki:resources.js As I said in the first reply, "xwiki:resources.js" is an odd name for a page which makes me think that an URL is badly parsed somewhere. Again, what version of XWiki Enterprise did you use? > Wrapped Exception: Failed to evaluate content with id [xwiki:resources.js]</a><div id="xwikierror1" style="display: none;"><pre class="xwikierror"> > Error number 4001 in 4: Error while parsing velocity page xwiki:resources.js > Wrapped Exception: Failed to evaluate content with id [xwiki:resources.js] > com.xpn.xwiki.XWikiException: Error number 4001 in 4: Error while parsing velocity page xwiki:resources.js > Wrapped Exception: Failed to evaluate content with id [xwiki:resources.js] > at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:122) > at com.xpn.xwiki.render.XWikiVelocityRenderer.render(XWikiVelocityRenderer.java:93) > at com.xpn.xwiki.render.XWikiVelocityRenderer.interpret(XWikiVelocityRenderer.java:55) > at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderText(DefaultXWikiRenderingEngine.java:269) > at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.interpretText(DefaultXWikiRenderingEngine.java:175) > at com.xpn.xwiki.XWiki.parseContent(XWiki.java:1610) > at com.xpn.xwiki.web.SkinAction.renderFileFromFilesystem(SkinAction.java:239) > at com.xpn.xwiki.web.SkinAction.render(SkinAction.java:133) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:214) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) > at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) > at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) > at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) > at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:152) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:117) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:295) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) > at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) > at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:859) > at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:574) > at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1527) > at java.lang.Thread.run(Unknown Source) > > > Wrapped Exception: > > org.apache.velocity.runtime.parser.TemplateParseException: Encountered "+ markerId + " at xwiki:resources.js[line 47, column 27] > Was expecting one of: > "," ... > ")" ... > > at org.apache.velocity.runtime.parser.Parser.parse(Parser.java:119) > at org.apache.velocity.runtime.RuntimeInstance.parse(RuntimeInstance.java:1131) > at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:184) > at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:156) > at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:116) > at com.xpn.xwiki.render.XWikiVelocityRenderer.render(XWikiVelocityRenderer.java:93) > at com.xpn.xwiki.render.XWikiVelocityRenderer.interpret(XWikiVelocityRenderer.java:55) > at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderText(DefaultXWikiRenderingEngine.java:269) > at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.interpretText(DefaultXWikiRenderingEngine.java:175) > at com.xpn.xwiki.XWiki.parseContent(XWiki.java:1610) > at com.xpn.xwiki.web.SkinAction.renderFileFromFilesystem(SkinAction.java:239) > at com.xpn.xwiki.web.SkinAction.render(SkinAction.java:133) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:214) > at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) > at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) > at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) > at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) > at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:617) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:152) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:117) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:295) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) > at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) > at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) > at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) > at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) > at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) > at org.apache.coyote.http11.Http11AprProcessor.process(Http11AprProcessor.java:859) > at org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Http11AprProtocol.java:574) > at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1527) > at java.lang.Thread.run(Unknown Source) > > </pre></div> > > Here is what I did, I first created a edit panel: > > > #panelheader('DesignRationaleTreeView') > > $xwiki.jsfx.use("js/xwiki/designrationaletreeview/designrationaletreeview.nocache.js", true) > > <div id="DR_TreeView"></div> > > > #panelfooter() An advice: don't leave useless empty lines in the panel content because they generate paragraphs. Two questions: (1) do you get the same velocity exception when viewing the Panels.YourPanelName page? (2) When you get the velocity exception, is your JavaScript file loaded properly? Check with firebug in the header of the edited page for the associated script tag. Hope this helps, Marius > > In my GWT application I used to inject javascript > > String hookId = "DR_TreeView"; > > > RootPanel.get(hookId).add(outer); > > > > > Thank you everyone, have a nice day! > > Leon >

15 years

[xwiki-devs] [UX][Proposal] Action Menu in Edit Mode

by Ecaterina Valica

Hi, We should replace the "Choose Editor" panel by using the Action Menu also in Edit Mode. Please comment on this and select your favorite variant: A, B, C, D, E http://incubator.myxwiki.org/xwiki/bin/view/Improvements/ActionMenuEditImpr… Thanks, Caty

15 years

[xwiki-devs] Analysis of the XWiki 2.0 grammar

by Andreas Jonsson

Hello, I have made a complete analysis of and made extensive changes to the XWiki grammar file to make the grammar strictly LL(1). Please have a look here: http://code.google.com/p/wikimodel/issues/detail?id=169 Below is a summary of things that I find surprising in the XWiki grammar, and we should consider changing: Unexpected: Parameters at the beginning of line terminates a block or a paragraph, even if they are inline to the line. Expected: Only empty lines or appropriate end-tokens may terminate a block or a paragraph. Alternatively, the parameters may terminate a block or paragraph if they are indeed block parameters. Unexpected: No empty lines event is generated if there are exactly two new lines before something that is not a paragraph. Expected: Empty lines event should always be generated on sequences of two or more new lines characters. Unexpected: Header tokens can be arbitrarily long sequences of equal signs. If there are more than six, header level 6 is chosen. The optional end token does not need to match the start token. Expected: Sequences of more than 6 equal signs should be special characters. Mismatching end tokens should be special characters. Unexpected: If there are block parameters before an empty line, an empty paragraph is generated and the parameters are applied to these. Expected: Block parameters should be applied to the following header, table, paragraph etc. Best regards, Andreas Jonsson

15 years

[xwiki-devs] [Proposal] Refactoring registration page and add some apis

by Caleb James DeLisle

Hello all, I am working on refactoring the registration page. I have a mockup which uses the view action so that the register action is not needed, I'm not sure if it makes more sense to remain a template or be moved to an application, any thoughts on this? There are a few apis which would make this job a lot easier and cleaner. I would like to provide Velocity access to ConfigurationSource. There would be a configuration parameter which a list of configuration parameters that Velocity is allowed to read. I think it makes the most sense to add a VelocityContextInitializer to the default Configuration implementation which injects a ConfigurationSource wrapper. Perhaps name it $configurationsource Currently (in my mockup) there is no way to tell the guest who is registering that their chosen user name is taken or is invalid if the captcha is wrong, this is because the username is checked by $xwiki.createUser after the captcha is verified. If we add the following two apis then all of the checking can be done on the Velocity side. $xwiki.isUsernameAvailable(String name) This will check if the name is the name of the superuser then check if a document exists by that name. Should I be using an EntityReference? I lean toward string because that is what the user types in. $util.compilePattern(String regex) Returns a Pattern or null if regex is invalid because Perl5Util methods all throw exceptions which Velocity can't catch. I appreciate any thoughts/advice you have to offer. Thanks, Caleb

15 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

xwiki-devs