[xwiki-devs] Components versus plugins

Hi devs, I'm working currently on the new comments and ratings plugins. The objective is to allow to separate the comment code from the core to allow different implementation which can be: - comments as objects to the page (the current implementation) - comments as separate pages - ratings separated from comments - comments and ratings merged We have code in the sandbox http://svn.xwiki.org/svnroot/xwiki/sandbox/plugins/comments/src/main/java/c… There is a patch for the core to call the comments code in the sandbox also. Now we have currently used a plugin oriented entry point which calls a CommentsManager which is a separate module. It does not seem very practical to call the plugin from the core. I've been thinking that it would be better to make the CommentsManager a component, with the interface in the core, and separate the implementations in a comments component in the xwiki-core-comments. The approach would be similar to Artem's approach on the query plugin. Then we would use a velocity bridge to expose the comments to the velocity scripting. Is that the right approach ? Is there documentation to help me achieve this ? Can some of our core devs looks at the comments code and provide some feedback to improve this. I think we can improve it significantly. We need comments and ratings as separate pages pretty quickly so we need feedback very soon to be able to take it into account. WDYT ? Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost