On Fri, Nov 2, 2018 at 3:40 PM Simon Urli <simon.urli(a)xwiki.com> wrote:
On 02/11/2018 12:32, Ecaterina Moraru (Valica) wrote:
K, but we should preserve the position of the
button, even though we
don't
have checkboxes, so C2 would be the solution, but
instead of button, we
should reuse the Livetable actions styling. WDYT?
I'm ok with preserving the position of the button.
Now regarding the kind of button we want to display, I'm a bit afraid
that using the same delete icon might be confusing for the user, and
that he'd need to click on it to understand it's a "delete all".
I also want to have consistency but we need to make obvious the role of
this button.
<off topic>
Side remark about the icon used in this livetable: it seems that for the
icons actions we're not using the Icon Theme Application
(
https://extensions.xwiki.org/xwiki/bin/view/Extension/Icon%20Theme%20Applic…),
is it on purpose?
</off topic>
Simon
On Fri, Nov 2, 2018 at 1:27 PM Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com> wrote:
> On Fri, Nov 2, 2018 at 1:13 PM Ecaterina Moraru (Valica) <
> valicac(a)gmail.com>
> wrote:
>
>> What's the difference between C2 and D?
>
>
> D is about allowing the user to select the pages to delete. This means
> having a checkbox on each row to be able to select it and having a
Select
> All / None buttons / links to select all rows
or none.
>
> C is about all or none, no custom selection.
>
>
>> For me it's the same thing. You
>> just used button instead of the livetable styling for actions. In D,
I'm
>> showed how it would look like with
multiple actions, but if you remove
> the
>> Restore, and keep just Delete All, C2 and D it's the same thing. And I
>> prefer this version.
>>
>> Thanks,
>> Caty
>>
>> On Fri, Nov 2, 2018 at 1:01 PM Marius Dumitru Florea <
>> mariusdumitru.florea(a)xwiki.com> wrote:
>>
>>> If you put it in the Actions column then you need to have space for a
>>> "Restore all" button or any other bulk action that we may add
later.
It
>>> looks OK with one button but it
doesn't look good IMO with two big
>> buttons.
>>>
>>> Thanks,
>>> Marius
>>>
>>> On Fri, Nov 2, 2018 at 12:48 PM Simon Urli <simon.urli(a)xwiki.com>
> wrote:
>>>
>>>> Hi all,
>>>>
>>>> I just edited the design page to propose two variants for the place
> of
>>>> the button in C :
>>>>
>>>>
>>>
>>
>
https://design.xwiki.org/xwiki/bin/view/Proposal/Deleteallfromrecyclebin#HV…
>>>>
>>>> Don't hesitate to give me some feedback or to propose other design.
>>>>
>>>> Simon
>>>>
>>>> On 02/11/2018 10:10, Marius Dumitru Florea wrote:
>>>>> On Wed, Oct 31, 2018 at 1:19 PM Ecaterina Moraru (Valica) <
>>>> valicac(a)gmail.com>
>>>>> wrote:
>>>>>
>>>>>> I don't like solution C. It will not be consistent with
anything
> and
>>>> will
>>>>>> look horrible.
>>>>>>
>>>>>
>>>>> We have a few places where we have buttons above / below the live
>>> table:
>>>>>
>>>>> * Wiki index (Create Wiki above the live table)
>>>>> * Licensed Extensions (Check for Updates below the live table)
>>>>> * Users Administration section (Create User below the live table)
>>>>> * Groups Administration section (Create Group below the live table)
>>>>> * Data Type (Create this Class above the live table)
>>>>> * Class Sheet (Create this Page above the live table)
>>>>>
>>>>> So I don't see the problem with option C.
>>>>>
>>>>> Thanks,
>>>>> Marius
>>>>>
>>>>>
>>>>>>
>>>>>> On Wed, Oct 31, 2018 at 10:38 AM Simon Urli
<simon.urli(a)xwiki.com
>>
>>>> wrote:
>>>>>>
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> thanks for your answers.
>>>>>>> I'll do solution C for the next release then, we can
continue
>> discuss
>>>>>>> about D in the dedicated issue.
>>>>>>>
>>>>>>> Simon
>>>>>>>
>>>>>>> On 29/10/2018 16:23, Guillaume Delhumeau wrote:
>>>>>>>> +1 for C.
>>>>>>>>
>>>>>>>> D could be nice but from the user perspective, I think a
big
>> button
>>>>>> like
>>>>>>>> "clear the recycle bin" is simpler than a
generic "bulk" action.
>>>>>>>>
>>>>>>>> Le lun. 29 oct. 2018 à 15:17, Adel Atallah <
>> adel.atallah(a)xwiki.com>
>>> a
>>>>>>>> écrit :
>>>>>>>>
>>>>>>>>> On Mon, Oct 29, 2018 at 3:09 PM Ecaterina Moraru
(Valica)
>>>>>>>>> <valicac(a)gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>> On Mon, Oct 29, 2018 at 4:06 PM Adel Atallah
<
>>>> adel.atallah(a)xwiki.com
>>>>>>>
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hello Simon,
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Oct 29, 2018 at 2:59 PM Simon Urli
<
>> simon.urli(a)xwiki.com
>>>>
>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>
>>>>>>>>>>>> I'll work this month on adding the
"delete all"
> functionality
>> in
>>>>>> the
>>>>>>>>>>>> recycle bin.
>>>>>>>>>>>> However I'd like to have your opinion
on how it should looks
>>> like
>>>>>> for
>>>>>>>>>>>> the users.
>>>>>>>>>>>> I have at least 4 proposals that I
detailed there:
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>
>>
https://design.xwiki.org/xwiki/bin/view/Proposal/Deleteallfromrecyclebin
>>>>>>>>>>>>
>>>>>>>>>>>> The 4 proposal are numbered as
following:
>>>>>>>>>>>>
>>>>>>>>>>>> A. A simple button
>>>>>>>>>>> -1
>>>>>>>>>>>> B. A simple button with a checkbox
to activate it
>>>>>>>>>>> -0 as it feels a bit weird.
>>>>>>>>>>>> C. A button and a modal to confirm
the action
>>>>>>>>>>> +1
>>>>>>>>>>>> D. A generic bulk action on the
livetable
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> +1 for D. but since it involves multiple
documents, we will
> also
>>>>>> need a
>>>>>>>>>> confirmation for these actions. So the solution
would be a mix
>>>>>> between
>>>>>>>>> D. +
>>>>>>>>>> C.
>>>>>>>>>> If we implement D. we will have the base for
multiple other
> use
>>>>>> cases,
>>>>>>>>>> since this needs is recurrent.
>>>>>>>>>
>>>>>>>>> It would be great to list the possible use cases to
see if the
>>>>>>>>> development of this feature is worth the effort. For
now, the
>> only
>>>> use
>>>>>>>>> case that comes to my mind is for the deletion
action.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Caty
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> +1, this is probably the best solution but
also more
>> complicated
>>> to
>>>>>>> do.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks in advance for your feedbacks.
>>>>>>>>>>>>
>>>>>>>>>>>> Simon
>>>>>>>>>>>> --
>>>>>>>>>>>> Simon Urli
>>>>>>>>>>>> Software Engineer at XWiki SAS
>>>>>>>>>>>> simon.urli(a)xwiki.com
>>>>>>>>>>>> More about us at
http://www.xwiki.com
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Adel
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Simon Urli
>>>>>>> Software Engineer at XWiki SAS
>>>>>>> simon.urli(a)xwiki.com
>>>>>>> More about us at
http://www.xwiki.com
>>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Simon Urli
>>>> Software Engineer at XWiki SAS
>>>> simon.urli(a)xwiki.com
>>>> More about us at
http://www.xwiki.com
>>>>
>>>
>>
>
--
Simon Urli
Software Engineer at XWiki SAS
simon.urli(a)xwiki.com
More about us at
http://www.xwiki.com