Re: [xwiki-dev] [Checkstyle] Coding rules

Hi, I have just made my first code commits. However, I had no code rules to go by so I've tried to copy existing code. The problem is that the existing code is not consistent itself!... I would like us to define what are our coding rules. Questions such as: - max number of characters on a ligne. 100? 120? More? - indentation rules - spacing rules, like "(SomeClass)myobject" or "(SomeClass) myobject" - etc We could of course have a wiki topic for describing the rules but I don't think that's the right approach. I would prefer doing what I've done on my other projects: have a checkstyle.xml file describing those rules and apply them in the build. ATM as we have lots of inconstancies, the build would not fail on checkstyle error. However we should work towards eliminating checkstyle violations and move the checks, one by one, from warning to error (error fails the build). WDYT? Thanks -Vincent _____________________________________________________________________________ Découvrez le nouveau Yahoo! Mail : 1 Go d'espace de stockage pour vos mails, photos et vidéos ! Créez votre Yahoo! Mail sur http://fr.mail.yahoo.com ------------------------------------------------------------------------ -- You receive this message as a subscriber of the xwiki-dev(a)objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws