Re: [xwiki-devs] Map Application - GSoC 19

Hi Caty, Thanks for the review. This space exists only for testing. It won't be there for the real application. I named them so that its easier to know which type of object pages are located in them (for myself). MapTesting, Maps, Points - spaces don't have homepages. The users will Since we are in the beta stage now, the whole MapTesting space exists for testing for developers. It would not be there once we have a stable version ready for release. Lots of pages that are not hidden. All technical pages needs to be Again, these pages are not technical and exist only for testing purposes. A bit confusing that there are 2 search boxes for the maps, see Yes, thanks for pointing out. We need to move the search function directly inside the map. I will look into it once I am done with the facets. For the search input, its in extremely beta stage. I am still trying to figure out the macros I have borrowed from SolrSearchMacros. So it will take time for me to make a more stable version of the facets. I hope I can do that in due time. :) Regarding the facets, we need some more user friendly translations and As discussed earlier with Stephane, we are still having issues using the normal $facetDisplayer so we are using a workaround for testing purposes that's why it looks like this. More precisely, we are using the #displaySearchFacetValues($facetValues) macro for now. Best, Fawad On Fri, Jun 7, 2019 at 5:18 PM Ecaterina Moraru (Valica) &lt;valicac(a)gmail.com&gt; wrote: > Hi, > > On Fri, Jun 7, 2019 at 2:01 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; wrote: > >> Hi all, >> Hope you all are doing wonderfully. >> >> We still have the issue for the facets rendering but its up on the forum, >> so I think we will have some fixes for it in due time (thanks to Stephane). >> In the meantime, I will try making the facets more specific to the map. >> For now I am considering the following options for facets: >> - Tags >> - Search field (searches inside map item pages) >> - Map item type (PointClass for now) >> - Map item icon (?) >> - Map item space >> I will need some suggestions on which other options should be included. >> >> Next, I will >> - Be working on making a dedicated space for popups inside or besides >> the map. Something similar to https://abc.gogocarto.fr >> - Make use of theme styles and colors for the map itself and the items >> inside >> - Be making the query search asynchronous >> >> Also, I will be working part time for the next week and I have exams the >> week after that. So I would like to let you know that I would not be >> available for the exams period for the most part. :( >> I will try to finish most of the work and get the application in a stable >> state by then. :) >> Ecaterina also mentioned that we release the application, I propose we do >> that next week as soon as the facets are in a stable state. >> > > That would be great in order for people to faster install it and test it. > You could also request feedback on the forum if you want. > When releasing you also need to write the documentation for the existing > features, mentioning how to use them, etc. + list the fixed issues. > > I managed to get the maps working. Thanks for your help. > Some comments on the current state: > - Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space is > duplicated > - MapTesting, Maps, Points - spaces don't have homepages. The users will > navigate to them, since they are present in breadcrumb. So what is the > plan? Simpler paths? or create Homepages for these types of entry? > - Lots of pages that are not hidden. All technical pages needs to be > hidden. > - A bit confusing that there are 2 search boxes for the maps, see > - The Search input is not really working. It kind of works (with a strange > reload effect) for queries like "Paris" or "Moscow", but if you enter > anything else it defaults on Paris. If that search is supposed to filter > only the existing points than the placeholder should state that somehow + > treat the non existing point with a "No point of interest found" or > something. Also when it doesn't find the location, the search facets area > is empty, so kind of hard for an user to recover it's track. > - Regarding the facets, we need some more user friendly translations and > > Thanks, > Caty > > >> Thanks, >> Fawad >> >> >> On Thu, Jun 6, 2019 at 6:42 PM Ecaterina Moraru (Valica) < >> valicac(a)gmail.com&gt; wrote: >> >>> That most likely is the problem, since I've just imported the XAR, no >>> real install. I will try like that, thanks for helping. >>> >>> Caty >>> >>> On Thu, Jun 6, 2019 at 1:03 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>> wrote: >>> >>>> Hi Caty, >>>> >>>> The last thing to be wary of is to have the Leaflet dependency >>>> installed. >>>> If I remove my Leaflet webjar, I get this set of errors. >>>> >>>> GET >>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.css >>>> net::ERR_ABORTED 404 (Not Found) >>>> require.min.js?r=1:34 GET >>>> http://ginpachi-pc:8080/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1 >>>> net::ERR_ABORTED 404 (Not Found) >>>> require.min.js?r=1:7 Uncaught Error: Script error for "leaflet", needed >>>> by: leafletSearch >>>> http://requirejs.org/docs/errors.html#scripterror >>>> at F (require.min.js?r=1:7) >>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30) >>>> >>>> I think Its the same problem your side. >>>> For installing Leaflet, search for Map Macro in extensions, from its >>>> dependencies tab in details go to Leaflet and install it. >>>> That ought to work. :) >>>> >>>> Best, >>>> Fawad >>>> >>>> >>>> On Thu, Jun 6, 2019 at 2:24 PM Ecaterina Moraru (Valica) < >>>> valicac(a)gmail.com&gt; wrote: >>>> >>>>> Hi Fawad, >>>>> >>>>> I still have the issue: no maps loaded, leaflet.css error in console. >>>>> Tested with the most recent snapshot of 11.5 and with the build from >>>>> https://github.com/xwiki-contrib/application-interactive-maps >>>>> I have the same problem with Firefox, Chrome, Safari and Opera. I'm on >>>>> Mac. >>>>> https://up1.xwikisas.com/#mXONZtF2qcMeftvnyJOSjw >>>>> The script from “ >>>>> http://localhost:8084/xwiki/webjars/wiki%3Axwiki/leaflet/leaflet.js?r=1” >>>>> was loaded even though its MIME type (“text/html”) is not a valid >>>>> JavaScript MIME type. >>>>> >>>>> Also Maps.MapTesting.Points.Islamabad.WebHome page seems to have >>>>> error when importing (with the "Replace the page history with the >>>>> history from the package" option) >>>>> https://up1.xwikisas.com/#ag8AIsPHgcFYqVod2RMJQQ >>>>> >>>>> Thanks, >>>>> Caty >>>>> >>>>> >>>>> On Wed, Jun 5, 2019 at 8:50 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>> wrote: >>>>> >>>>>> I just built and imported the application from my own repo ( >>>>>> https://github.com/9inpachi/interactive-maps-new) and everything >>>>>> seems fine. >>>>>> >>>>>> There was that error in the more earlier builds but it was fixed, may >>>>>> be some of the source files (especially Leaflet.xml) are old? >>>>>> Try building the source files anew with "mvn clean install". May be >>>>>> that will help. >>>>>> >>>>>> Thanks, >>>>>> Fawad >>>>>> >>>>>> On Wed, Jun 5, 2019, 10:37 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com >>>>>> wrote: >>>>>> >>>>>>> We have shifted the repo to xwiki-contrib again. You may try that. I >>>>>>> will also check my own repo for any errors ASAP. >>>>>>> >>>>>>> Best, >>>>>>> Fawad >>>>>>> >>>>>>> On Wed, Jun 5, 2019, 10:35 PM Ecaterina Moraru (Valica) < >>>>>>> valicac(a)gmail.com wrote: >>>>>>> >>>>>>>> I've used the latest build from >>>>>>>> https://github.com/9inpachi/interactive-maps-new >>>>>>>> and I have the error both on 11.4-rc-1 and some 11.4-snapshot. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Caty >>>>>>>> >>>>>>>> On Wed, Jun 5, 2019 at 8:30 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Caty, do you have the error with the latest git repo as well? >>>>>>>>> Actually the leaflet-commons require leaflet but the functions are >>>>>>>>> not actually called anywhere without the leaflet dependency used in require. >>>>>>>>> >>>>>>>>> There is no error on my or Stephane side. >>>>>>>>> I have the 11.3-rc version of XWiki. >>>>>>>>> You can try Ctrl+F5 for a complete new load of the resources. >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> Fawad >>>>>>>>> >>>>>>>>> On Wed, Jun 5, 2019, 10:22 PM Ecaterina Moraru (Valica) < >>>>>>>>> valicac(a)gmail.com wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Some notes: >>>>>>>>>> - We don't have guidelines regarding the singular / plural thing. >>>>>>>>>> I'm glad that on the new sources we don't have the Maps/Map anymore. I'm >>>>>>>>>> fine with Maps. In practice we have a mix of singular (like Diagram, >>>>>>>>>> Calendar, Meeting) and plural (like Ideas, Forums). I prefer the plural >>>>>>>>>> version, although in practice I think we have more with singular. There was >>>>>>>>>> a tentative old draft for having such guidelines >>>>>>>>>> https://design.xwiki.org/xwiki/bin/view/Proposal/ApplicationGuidelines >>>>>>>>>> but we didn't worked on it for some time. >>>>>>>>>> >>>>>>>>>> - Regarding the new Git repository. Since you've committed the >>>>>>>>>> initial commits in issues, you should do a release with the initial >>>>>>>>>> version, and than just release a new version for the interactive-maps-new . >>>>>>>>>> It's normal in an application's development flow that changes happen, >>>>>>>>>> that's why versioning schemes are all about. >>>>>>>>>> >>>>>>>>>> - I still have the error I've mentioned before : >>>>>>>>>> Uncaught Error: Script error for "leaflet", needed by: >>>>>>>>>> leafletSearch >>>>>>>>>> http://requirejs.org/docs/errors.html#scripterror >>>>>>>>>> at F (require.min.js?r=1:7) >>>>>>>>>> at HTMLScriptElement.onScriptError (require.min.js?r=1:30) >>>>>>>>>> >>>>>>>>>> leaflet.css:1 Failed to load resource: the server responded with >>>>>>>>>> a status of 404 (Not Found) >>>>>>>>>> >>>>>>>>>> so I cannot actually test the build, since I don't see the maps. >>>>>>>>>> I have this both on Chrome and Firefox. Do I need to do something? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> On Tue, Jun 4, 2019 at 2:31 PM Fawad Ali &lt;m.fawaadali98(a)gmail.com&gt; >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Also, I forgot to mention it before but we will need a better >>>>>>>>>>> and more expressive way to show popups. We need something that can >>>>>>>>>>> accomodate sufficient amount of text with a scroll if the information >>>>>>>>>>> exceeds the page. >>>>>>>>>>> I will prepare a mockup for this once I am done with some of the >>>>>>>>>>> next steps. >>>>>>>>>>> >>>>>>>>>>> And I think we should use the colortheme colors for our map >>>>>>>>>>> controls and consequently for the popups. I will update you on that as well. >>>>>>>>>>> >>>>>>>>>>> Best, >>>>>>>>>>> Fawad >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Tue, Jun 4, 2019 at 3:31 PM Fawad Ali < >>>>>>>>>>> m.fawaadali98(a)gmail.com&gt; wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Stephane, Caty and all, >>>>>>>>>>>> Hope you are doing fine. >>>>>>>>>>>> >>>>>>>>>>>> I am glad you brought up the topic of custom marker icon. I am >>>>>>>>>>>> well aware of the issue. Actually there are two problems with custom >>>>>>>>>>>> markers. >>>>>>>>>>>> - The icon offset >>>>>>>>>>>> - The document attachment >>>>>>>>>>>> >>>>>>>>>>>> For the icon offset, when I tried to fix it initially it seemed >>>>>>>>>>>> that I can overcome the offset either by height or width which means that >>>>>>>>>>>> the offset still exists from a single side so I had that postponed since I >>>>>>>>>>>> thought solr query tasks take priority. >>>>>>>>>>>> >>>>>>>>>>>> For the attachment, for now I am getting the first attachment >>>>>>>>>>>> (0th index) from the Point page which is not very reliable. For example if >>>>>>>>>>>> we have images on the page, it could be that the marker takes one of the >>>>>>>>>>>> attachments even if the user did not want a custom icon or an image >>>>>>>>>>>> different from what the user wanted to choose is selected as the marker >>>>>>>>>>>> icon. >>>>>>>>>>>> >>>>>>>>>>>> What I have in mind is that we define categories for marker >>>>>>>>>>>> icons dynamically. >>>>>>>>>>>> We could make a separate dedicated page "MarkerIcons" and >>>>>>>>>>>> attach multiple images to it. Then these images could appear in a list as >>>>>>>>>>>> one of the properties in the Point object where we can choose the icon >>>>>>>>>>>> from. WDYT? >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Fawad >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Jun 4, 2019, 11:31 AM Stéphane Laurière < >>>>>>>>>>>> slauriere(a)xwiki.com wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Fawad, Thanks for letting us know, I could install the new app >>>>>>>>>>>>> version, I confirm that all the changes you added to the progress file >>>>>>>>>>>>> (very handy) work for me, and the refactoring is ok. I noticed a minor >>>>>>>>>>>>> issue that you're certainly aware of already: it seems there's a small >>>>>>>>>>>>> offset between the custom marker position (with the Islamabad point) and >>>>>>>>>>>>> the popup position. >>>>>>>>>>>>> >>>>>>>>>>>>> Talk to you soon, >>>>>>>>>>>>> >>>>>>>>>>>>> Stéphane >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Fawad Ali: >>>>>>>>>>>>> > Hi all, >>>>>>>>>>>>> > >>>>>>>>>>>>> > Thanks for the detailed review, Stephane. I have made the >>>>>>>>>>>>> changes you suggested with some next steps also done. >>>>>>>>>>>>> > >>>>>>>>>>>>> > Furthermore, I will make changes to the application space >>>>>>>>>>>>> once we have confirmed response from Caty or other developers. >>>>>>>>>>>>> > I have started to work on the other next steps and will >>>>>>>>>>>>> provide with updates soon. >>>>>>>>>>>>> > >>>>>>>>>>>>> > The original github repo is also updated, so future updates >>>>>>>>>>>>> will be available at >>>>>>>>>>>>> https://github.com/xwiki-contrib/application-interactive-maps. >>>>>>>>>>>>> > >>>>>>>>>>>>> > Thanks, >>>>>>>>>>>>> > Fawad >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Stéphane Laurière >>>>>>>>>>>>> XWiki – https://xwiki.com >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>