Re: [xwiki-devs] Integration of ratings in xwiki-platform

The new module can be a new version of the one on xwiki-contrib and not break the extensions that have a dependency to the old module. The script service basically remains intact. The methods contained by that service maintain the same signatures. Nothing has changed from this point of view. So previous versions of the ratings module (the ones from contrib) can use the service just as before without it breaking things. The issue that arises from changing the package name is that any code that uses classes from that package explicitly will be broken. Example: ----- Say you have a java or groovy script in which you want to use a class from the ratings api package or typed variables. That code will be broken due to the fact that packages don't match anymore. org.xwiki.contrib.ratings.Rating myRating = new org.xwiki.contrib.ratings.Rating(); or org.xwiki.contrib.ratings.RatingAPI myRating = services.ratings.getRating(doc, author); on the other hand services.ratings.getRating(doc, author).getVote(); should be ok The question is: ----- Is there somebody who used classes from the api package in their code or the use of this module has been limited to calling the service from velocity and just setting/getting votes? Thanks, Victor On Wed, Dec 3, 2014 at 5:30 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com> wrote: