10 Nov
2010
10 Nov
'10
10:18 p.m.
On 11/10/2010 09:55 PM, Ecaterina Moraru (Valica) wrote:
XE-749 fixed the problem of not showing comments, but
is not only about the
Activity Stream, it about the consistency and as Thomas was saying, is about
having similar objects have similar behavior. That's why we should revise
the code.
Yes, +1, but IMO the correct behavior is minor edits for everything.
Most actions create major revisions by default for historical reasons.
Initially there was no support for major versions, everything was minor.
Neither was there support for version comments. So, there was only one
method, xwiki.saveDocument(doc, context), and this was and still is the
method used by most code. When support for major versions was
introduced, the default saveDocument was changed so that it creates
major versions, but the code that used that method wasn't updated to use
the new method which allows entering a version summary and specifying a
minor edit.
On Wed, Nov 10, 2010 at 22:01, Sergiu Dumitriu<sergiu(a)xwiki.com> wrote:
> On 11/10/2010 02:35 PM, Guillaume Lerouge wrote:
>> Hi XWiki Devs,
>>
>> I've been performing some XWiki demos recently and it came to my
> attention
>> that when adding a comment to a page and then going back to the homepage,
> my
>> comments didn't show up in the recent activity section of the dashboard.
>> This is due to the fact that adding a comment is considered a minor
> event.
>>
>> This behavior is still taking place in the most recent versions of XWiki
>> Enterprise (I tested a XE 2.7 snapshot this morning). I believe that
>> comments should be treated as major events, the same way that adding an
>> object or an annotation to a page is.
>>
>> Therefore I propose making adding a comment a major event instead of a
> minor
>> one.
>>
>> Here's my +1 for this.
>
> -1, since the main part of the document is the content. Ideally, adding
> comments should not even be part of the main history, but something
> displayed in a "detailed history".
>
> I think that adding objects and annotations should be minor edits as
> well. I'm not entirely sure about attachments, but I'm inclining towards
> minor.
>
> The problem is that the old dashboard used the wrong method for
> selecting the elements to display, but this should change with the new
> activity implementation. The fact that the new activity macro doesn't
> list comments should be fixed already by
> http://jira.xwiki.org/jira/browse/XE-749 , and I think that XE-749 is
> the right approach for the long term.
>
>> Thanks,
>>
>> Guillaume
>
> You're welcome,
>
> Sergiu
--
Sergiu Dumitriu
http://purl.org/net/sergiu/