Re: [xwiki-devs] [proposal] Process to handle Pull Requests

I don't think we can modify the GitHub pull request UI (https://github.com/xwiki/xwiki-platform/pulls for platform) which would have been best. Now this can be either: 1/ put the status in a comment to the pull request and manage all that manually 2/ put the status a comment to the pull request and manage an XWiki page that finds the latest STATUS published in a pull request using the github API (http://developer.github.com/v3/pulls/comments/) 3/ use an AppWithinMinutes application to manage the pull request statuses. Using the pull request API the XWiki page could be automatically be created and also send status changes as comments to the pull request

My post is not that much about where the statuses would be than about asking for a pull request process which will make sure we don't let pull request sleep without having anybody being responsible and wasting contributors' work because of a lack of organization. Ludovic 2012/8/9 Thomas Mortagne <thomas.mortagne(a)xwiki.com>om>: > > Where exactly do you propose this status to be indicated (I may have > missed it) ? > > On Thu, Aug 9, 2012 at 12:23 PM, Ludovic Dubost <ludovic(a)xwiki.com> > wrote: >> >> Hi devs, >> >> I don't think there is currently a process that is in place to handle >> pull requests and I have the feeling that the way there are handled >> today is a bit random. >> There are usually comments sent out on each pull request but sometimes >> it seems that some pull requests are going in sleep mode and it's not >> clear who is in charge. >> >> I would like to suggest that a process is put in place where it's >> clear who is responsible for a pull request and a status is given to >> the contributors that propose that pull request. >> >> Something like: >> >> Assigned developer: XXXX >> Status: >> New -> new pull request, not yet assigned >> Assigned -> assigned to a developer, he is in charge of reviewing the >> pull request and ask for modifications or accept it. The developer can >> auto assign it to himself. If nobody does, we need to decide how they >> will be taken into account. >> ModificationsRequired -> for now rejected with comments. Contributor >> needs to apply comments and then change back to Assigned for further >> evaluation >> VoteRequired -> there are no more comments, but a vote is required as >> the changes to XWiki core are important >> WaitingFinalAuthorization -> optional step for complex patches where >> a additional authorization would be required (need to define who would >> be the persons that give the authorization) >> WaitingApplication -> there are no more comments and no changes or >> vote required. The pull request can be applied and is waiting for a >> developer to apply it >> Abandoned -> contributors is abandoning the pull request (cannot do >> the changes, no more time, etc..) >> Rejected -> pull request is rejected (quality not enough, etc..) >> Applied -> pull request is applied >> >> What do you think ? >> >> Ludovic >> >> -- >> Ludovic Dubost >> Founder and CEO >> Blog: http://blog.ludovic.org/ >> XWiki: http://www.xwiki.com >> Skype: ldubost GTalk: ldubost >> _______________________________________________ >> devs mailing list >> devs(a)xwiki.org >> http://lists.xwiki.org/mailman/listinfo/devs > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs