Hi,
On Fri, Dec 5, 2008 at 9:22 AM, Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com> wrote:
Jean-Vincent Drean wrote:
Hi XWikiers,
I've made mockups for the WYSIWYG Image dialogs, you can see them at :
http://dev.xwiki.org/xwiki/bin/view/Design/NewWysiwygEditorInterface#HImage
Votes for internal image insertion :
1) Image size
------------------
In the mockup you can see a dropdown allowing to set some predefined
sizes to the image (inspired by google docs).
We could rely on the browser's image resizing feature for this and
drop this setting. I'm in favor of keeping it (see my votes below)
since it allow to keep size consistency between multiple images
(screenshots for example) in the same page.
Also, IE and FF have this resizing feature but we can't assume that
it'll be the same for all the browsers we will target in the future.
+1 since resizing to a specific width/height (say 147px) using the mouse
is not easy even in specialized applications.
2) Image size option
---------------------------
a) Allow to edit only the image width (guarantee that the image
width/height ratio won't be affected by the resize).
-0 since the user can resize the image, once it is inserted, without
keeping the width/height ratio. What will happen when he edits the
image? What ratio would be protected? The one before the resize or the
one after the resize?
b) Allow to edit both image width and height.
+1 provided the width/height ratio is locked by default (as it is in all
specialized applications).
3) Text flow
---------------
I think it's a must have but since it'll rely on a touchy parameter I
prefer that we vote for it.
Generated wiki syntax example : [[image:awsome.jpg||style="float:right"]]
Notes :
- for the moment using this will cause issues with titles, see :
http://www.jean-vincent.org/xwiki/bin/view/Main/Image
- I'm not sure that we'll be able to combine position center + text flow.
+1
4) Preview
--------------
I've put an image preview in the mockup, we've multiple choices:
a) Drop it since it makes the dialog heavy.
a) Keep it stupid simple, the image is represented by a placeholder
and the 6 possible states are "prerecorded" (could be images).
d) Make it an advanced preview, the image is the selected image, the
preview takes the size of the image into account (by calculating what
the selected size would look like compared to the page content in a
predefined resolution, like 1024x768).
+1 for b)
Votes for external image insertion :
5) Number of wizard steps
-----------------------------------
Like for the link insertion dialogs we have a major difference between
internal and external stuff. We could :
a) Have 2 steps to be consistent with the internal insertion. First
step : image URL, second step : image options.
b) Ease the edit work and have all the settings in the same screen,
this is how I've presented it in the mockup.
+1 for b)
My votes :
1) +1
2) +1 for a)
3) +1
4) +1 for d) if possible
5) +1 for b)
Thanks,
JV.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
1) +1, offering 3 standard image widths + "set custom width" seems good to
me.
2) +1 for letting the user edit only the image width (thus keeping the
ratio). The user will be able to break the ratio using his mouse back in
edit mode (which is bad but AFAIU we cannot prevent this, can we?).
3) +1
4) +1 for b) , an image placeholder seems good enough and is easy to
understand
5) +1 for b)
Guillaume