+0
Thanks,
Marius
On Tue, Jul 3, 2012 at 12:10 PM, Andreas Jonsson <aj(a)member.fsf.org> wrote:
Hi,
This vote is about adding the following three clirr excludes:
* This interface is completely refactored:
<exclude>org/xwiki/chart/model/ChartModel</exclude>
* This class is removed:
<exclude>org/xwiki/chart/model/DefaultChartModel</exclude>
* The constants 'SOURCE' and 'PARAMS' are removed from this interface:
<exclude>org/xwiki/rendering/macro/chart/ChartDataSource</exclude>
I am refactoring the chart macro and the interface 'ChartModel' is could
previously only be used for producing table-like datasets, but the jfree
chart library can produce plots from a wide range of dataset types. So the
new version of the interface is instead used for delivering the dataset and
the axis configuration to the chart generator.
I have deliberately choosed to not try abstracting away the fact that the
chart macro uses the jfree chart library. Doing so would require
introducing a large number of wrapper classes that would duplicate the
functionality existing classes and it would still not be particularly easy
to just plug in another chart library.
Here is my +1.
Best Regards,
/Andreas
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs