Re: [xwiki-devs] [VOTE] XWIKI-6990: Reduce the likelihood of having same (hibernate) document id for different documents

Hi devs, I need to fix, and I have a proposed commit at https://github.com/dgervalle/xwiki-platform/commit/068c24793dd77daa826765e3…

Basically, it does the following: a) Add XWikiDocument#getKey() which return a unique text key like 8:fullname2:fr b) Add XWikiDocument#getKey(context) which return a unique text key like 5:xwiki8:fullname2:fr c) Change XWikiDocument#getId() to use the lowest 64bits of an MD5 hash of XWikiDocument#getKey() d) Deprecate all XWikiCacheStore#getKey(...) and use XWikiDocument#getKey(context) for the XWikiCacheStore map e) Introduce a data migration to convert existing database, also fixing links, rcs, attachements and deleted attachements use of docid. I am +1 only after XWIKI-7006 is fixed (see my previous vote), since any improper access to an outdated database would corrupt it. Currently the patch is ready for 3.3, but if XWIKI-7006 goes in 3.2, I am also +1 to have this in 3.2. -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO