25 Aug
2014
25 Aug
'14
12:56 p.m.
2014-08-25 10:55 GMT+02:00 Eduard Moraru <enygma2002(a)gmail.com>om>:
Hi Guillaume,
On Mon, Aug 25, 2014 at 11:42 AM, Guillaume Louis-Marie Delhumeau <
guillaume.delhumeau(a)xwiki.com> wrote:
style.less.vm that imports (LESS imports, not standard CSS imports) other
less files and that you ultimately process and output a style.css to be
used by the skin.
What I was suggesting, to be consistent with colibri (and maybe with other
people's expectations that have maybe customised XWiki and are upgrading),
is that you use style.css (not style.less[.vm]) as a standard entrypoint in
the skin and have it "@import flamingo.css", where flamingo.css is actually
the output of a flamingo.less.vm where you do your LESS magic.
Does this make sense? Does anyone else identify this as a good practice,
something that we want or something that we need?
I got it, but it will be a problem with respond.js. Respond.js is used to
emulate the media queries on Internet Explorer 8, and it does not work for
css included by @import.
So if I have a file called style.css that does @import "flamingo.css", the
media queries that flamingo.css have will not be emulated by respond.js.
That is the problem.
I don't have an opinion about if your suggestion is a good practice or not.
I can imagine a benefit: the ability to easily customize style.css from the
wiki (in the administration), by adding custom styles after importing the
standard ones.
Hi Eddy,
2014-08-23 23:59 GMT+02:00 Eduard Moraru <enygma2002(a)gmail.com>om>:
Hi devs,
I`m asking because I don`t understand why otherwise this test was waiting
for an attachment on the homepage and how was it that it was working before.
Any idea why this test expects that the html export of the homepage
contains attachments? Is it expected for a document not containing
attachments to have an empty attachments folder in the exported html zip?
I don't know. Also did someone make a modifications in this area recently
?
Also, Guillaume, could you please have a look at my fix for the previous
fail reason of this test:
https://github.com/xwiki/xwiki-enterprise/commit/b9260b50a3f69a99c96a050208…
I committed that fix, but I am not sure why in flamingo we don`t (of if
we should) have the same type of content in style.css as we do for colibri
(i.e. @import flamingo.css). At a first glance, I was expecting it to be
consistent with colibri's style.css. Any thoughts on this?
Flamingo does not use @import because of Respond.js:
https://github.com/scottjehl/Respond
Respond.js doesn't parse CSS referenced via
@import, nor does it work
with media queries within style elements, as those styles can't be
re-requested for parsing.
AFAIU, you are currently handling LESS logic in style.css. You have a
If this is not the case of a backwards compatibility/consistency concern
OR if it is not technically possible with the new frameworks involved, then
maybe it's not that important as I had imagined it.
Thanks,
Eduard
Thanks,
Guillaume
So your fix seems good to me.
Thanks,
Eduard
On Sat, Aug 23, 2014 at 11:58 PM, Jenkins <build.noreply(a)xwiki.org>
wrote:
Thanks,
Guillaume
Check console output at
http://ci.xwiki.org/job/xwiki-enterprise-test-misc/3632/ to view the
results.
Changes since the previous successful build:
Changes for Build #3612
Changes for Build #3613
Changes for Build #3614
Changes for Build #3615
[Guillaume Delhumeau] Aug 18, 2014 12:24:23 PM XWIKI-10809: Move Font
Awesome Icon Theme in the Icon module.
(rev 77519cad877ea487b44e3fb1155a54df14c1dbe8)
Changes for Build #3616
[Guillaume Delhumeau] Aug 18, 2014 1:07:56 PM XWIKI-10809: Move Font
Awesome Icon Theme in the Icon module.
(rev d660fdd67064ae6ff0259b44cfe937b8597d8a8e)
Changes for Build #3617
[Guillaume Delhumeau] Aug 20, 2014 5:25:46 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 7c40f89248189af3486e4be631f5af9e1b566217)
[Guillaume Delhumeau] Aug 20, 2014 5:30:43 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 90f4d266e2bf70a383494066a8493f4ba0985101)
Changes for Build #3618
Changes for Build #3619
[Guillaume Delhumeau] Aug 20, 2014 5:49:43 PM XWIKI-10809: Move Font
Awesome Icon Theme in the Icon module.
(rev fb62b467cae9932774f56951adcc8a33d3dd36e2)
Changes for Build #3620
[Guillaume Delhumeau] Aug 20, 2014 6:22:10 PM XWIKI-10823: Rename the
LESS module artifacts.
(rev 56d184b40058fa529d794c9c04898d6b7f9f1686)
[Guillaume Delhumeau] Aug 20, 2014 6:52:16 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 41d771917b8e076a92c3bd370783c42867e086e1)
[Guillaume Delhumeau] Aug 20, 2014 7:01:26 PM XE-1404: Switch to
Flamingo Skin by default.
(rev a481aeaa498763c11b88a290ba76abb373be1bc5)
Changes for Build #3621
[Guillaume Delhumeau] Aug 21, 2014 1:12:35 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 65ede7701c8d2ad86238e1d17eca692f4646e368)
Changes for Build #3622
[Guillaume Delhumeau] Aug 21, 2014 1:58:27 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 655d0f6b1869749207543b1c9abb5399deaf38e7)
Changes for Build #3623
Changes for Build #3624
Changes for Build #3625
[Guillaume Delhumeau] Aug 21, 2014 5:48:59 PM XE-1404: Switch to
Flamingo Skin by default.
(rev 61720c645a9cc960a7673611e1d3c01ca5346057)
Changes for Build #3626
Changes for Build #3627
Changes for Build #3628
[Vincent Massol] Aug 22, 2014 12:53:09 PM [Misc] Revert changes done by
sdumitriu. The relativePath should not be set to not cause problems with
Jenkins. BTW I couldn't reproduce the build warning problem that Sergiu
fixed in his commit (would be interested to know more about it).
(rev a74558130c4625fdd1dd6c3e2b5b609ed6c39b44)
Changes for Build #3629
Changes for Build #3630
[Vincent Massol] Aug 22, 2014 5:34:44 PM [Misc] Force Maven to use its
repositories to resolve parent POM for top level modules. This is to
prevent any error such as having a pom.xml file located in a directory
above the top level modules for example.
(rev 172194e2764218ba6796f6fb4e6bd3972ca2ce66)
[Vincent Massol] Aug 22, 2014 6:19:43 PM XWIKI-10828: Speed up XWiki
instance starting in functional tests
(rev 6b00f7cd764aaab4522d1be7b65fff2c481d7a6e)
[Eduard Moraru] Aug 23, 2014 12:15:44 AM XE-1404: Switch to Flamingo
Skin by default.
(rev b9260b50a3f69a99c96a050208e92f8d71688c91)
Changes for Build #3631
Changes for Build #3632
Failed tests:
2 tests failed.
FAILED: org.xwiki.test.misc.HTMLExportTest.testHTMLExportPattern
Error Message:
Failed to find the attachment/ directory entry
Stack Trace:
junit.framework.AssertionFailedError: Failed to find the attachment/
directory entry
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.TestCase.assertTrue(TestCase.java:192)
at
org.xwiki.test.misc.HTMLExportTest.assertHTMLExportURL(HTMLExportTest.java:107)
at
org.xwiki.test.misc.HTMLExportTest.testHTMLExportPattern(HTMLExportTest.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at
junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
FAILED: org.xwiki.test.misc.HTMLExportTest.testHTMLExportCurrentPage
Error Message:
Failed to find the attachment/ directory entry
Stack Trace:
junit.framework.AssertionFailedError: Failed to find the attachment/
directory entry
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.TestCase.assertTrue(TestCase.java:192)
at
org.xwiki.test.misc.HTMLExportTest.assertHTMLExportURL(HTMLExportTest.java:107)
at
org.xwiki.test.misc.HTMLExportTest.testHTMLExportCurrentPage(HTMLExportTest.java:41)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at
junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Last build logs:
[...truncated 102973 lines...]
at
org.xwiki.test.misc.HTMLExportTest.assertHTMLExportURL(HTMLExportTest.java:107)
at
org.xwiki.test.misc.HTMLExportTest.testHTMLExportPattern(HTMLExportTest.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at
junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
testHTMLExportCurrentPage(org.xwiki.test.misc.HTMLExportTest) Time
elapsed: 4.936 sec <<< FAILURE!
junit.framework.AssertionFailedError: Failed to find the attachment/
directory entry
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.TestCase.assertTrue(TestCase.java:192)
at
org.xwiki.test.misc.HTMLExportTest.assertHTMLExportURL(HTMLExportTest.java:107)
at
org.xwiki.test.misc.HTMLExportTest.testHTMLExportCurrentPage(HTMLExportTest.java:41)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at junit.framework.TestSuite.runTest(TestSuite.java:255)
at junit.framework.TestSuite.run(TestSuite.java:250)
at
junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.extensions.TestSetup.run(TestSetup.java:27)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Results :
Failed tests:
HTMLExportTest.testHTMLExportPattern:50->assertHTMLExportURL:107
Failed to find the attachment/ directory entry
HTMLExportTest.testHTMLExportCurrentPage:41->assertHTMLExportURL:107
Failed to find the attachment/ directory entry
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
[ERROR] There are test failures.
Please refer to
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/xwiki-enterprise-test/xwiki-enterprise-test-misc/target/surefire-reports
for the individual test results.
[JENKINS] Recording test results
log4j:WARN No appenders could be found for logger
(org.apache.commons.beanutils.converters.BooleanConverter).
log4j:WARN Please initialize the log4j system properly.
[INFO]
[INFO] --- maven-install-plugin:2.5.1:install (default-install) @
xwiki-enterprise-test-misc ---
[INFO] Installing
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/xwiki-enterprise-test/xwiki-enterprise-test-misc/pom.xml
to
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/.repository/org/xwiki/enterprise/xwiki-enterprise-test-misc/6.2-SNAPSHOT/xwiki-enterprise-test-misc-6.2-SNAPSHOT.pom
[INFO] Installing
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/xwiki-enterprise-test/xwiki-enterprise-test-misc/target/xwiki-enterprise-test-misc-6.2-SNAPSHOT-tests.jar
to
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/.repository/org/xwiki/enterprise/xwiki-enterprise-test-misc/6.2-SNAPSHOT/xwiki-enterprise-test-misc-6.2-SNAPSHOT-tests.jar
[INFO]
[INFO] --- maven-deploy-plugin:2.8.1:deploy (default-deploy) @
xwiki-enterprise-test-misc ---
Downloading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Downloaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(835 B at 3.0 KB/sec)
Uploading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Uploaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(4 KB at 18.7 KB/sec)
Downloading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Downloaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(974 B at 6.3 KB/sec)
Uploading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Uploaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(835 B at 25.5 KB/sec)
Uploading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Uploaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(974 B at 6.1 KB/sec)
Uploading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Uploaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(115 KB at 883.1 KB/sec)
Uploading:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
Uploaded:
http://nexus.xwiki.org/nexus/content/repositories/snapshots/org/xwiki/enter…
(835 B at 32.6 KB/sec)
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 2:59.495s
[INFO] Finished at: Sat Aug 23 22:58:05 CEST 2014
[INFO] Final Memory: 49M/540M
[INFO]
------------------------------------------------------------------------
[WARNING] The requested profile "legacy" could not be activated because
it does not exist.
[WARNING] The requested profile "jetty" could not be activated because
it does not exist.
Waiting for Jenkins to finish collecting data
[JENKINS] Archiving
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/xwiki-enterprise-test/xwiki-enterprise-test-misc/pom.xml
to
org.xwiki.enterprise/xwiki-enterprise-test-misc/6.2-SNAPSHOT/xwiki-enterprise-test-misc-6.2-SNAPSHOT.pom
[JENKINS] Archiving
/home/hudsonagent/hudson_root/workspace/xwiki-enterprise-test-misc/xwiki-enterprise-test/xwiki-enterprise-test-misc/target/xwiki-enterprise-test-misc-6.2-SNAPSHOT-tests.jar
to
org.xwiki.enterprise/xwiki-enterprise-test-misc/6.2-20140823.205803-188/xwiki-enterprise-test-misc-6.2-20140823.205803-188-tests.jar
channel stopped
Terminating xvnc.
$ vncserver -kill :95
Killing Xtightvnc process ID 7445
Email was triggered for: Unstable (Test Failures)
Sending email for trigger: Unstable (Test Failures)