26 May
2014
26 May
'14
12:15 p.m.
Hi Lyes,
Done: https://github.com/xwiki-contrib/macro-dynamic-tree
Do you also need a JIRA project?
Thanks
-Vincent
On 21 May 2014 at 19:07:24, Anca Luca (lucaa@xwiki.com(mailto:lucaa@xwiki.com)) wrote:
Hello Devs,
As far as I know it's not a refactoring of the old macro because some
parameters / parameters behaviour was not kept 100%. It's missing some
features, basically. Adding some with the cost of removing others.
So if we consider it a new version of the old one, installing an "upgrade"
will break the behaviour. You'd tell me we could wait to release the new
version it only when ready, but then people could not take advantage of its
features (which are cool).
We could have it as a new extension until we implement all the features of
the old one, and then we mark it as implementing the same feature so that
the old one could be upgraded to the new one.
Anca
On Wed, May 21, 2014 at 7:11 PM, vincent(a)massol.net wrote:
On 21 May 2014 at 18:08:33, Lyes Bandou (lyes.bandou(a)xwiki.com(mailto:
lyes.bandou(a)xwiki.com)) wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs Code of the two macros is not the same,
This doesn’t matter much if the new code is considered a refactoring of
the old code.
The new macro has the same name and
keeps most paramettres, but the behavior is not the same it uses Ajax to
load the data (using JSON) and the older macro display the documents
hierarchy in a space , the new macro can uses documents list as documents
roots of the tree (plus another paramettres)
I suggest "Dynamic Tree Macro" as the new name.
The real question is: do we need the 2 macros at once?
I guess we need to ask the question to the author of the first macro:
Anca, Paul, Mircea.
Because from a user point of view, it’s a nightmare to have several
extensions doing the same thing, the user never knows which one to use.
Anca/Paul/Mircea, do you have an opinion?
Thanks
-Vincent
On Wed, May 21, 2014 at 4:40 PM, Thomas Mortagne
wrote:
> Same question, why is a new repository needed exactly ? If it's THE
> new version then it's the same extension and it should be the same
> repository, even if you rewrite half of it in a 2.0 version.
>
> On Wed, May 21, 2014 at 5:37 PM, vincent(a)massol.net
> wrote:
> > Do you really need a new extension? Couldn’t you improve the existing
> one then?
> >
> > Thanks
> > -Vincent
> >
> > On 21 May 2014 at 17:35:52, Lyes Bandou (lyes.bandou(a)xwiki.com
(mailto:
> lyes.bandou(a)xwiki.com)) wrote:
> >
> >> This is the new version of Hierarchy Macro (
> >> http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro
)
> with
> >> the addition of to many parameters
> >>
> >>
> >> On Wed, May 21, 2014 at 4:26 PM, Thomas Mortagne
> >> wrote:
> >>
> >> > Are you talking about
> >> >
http://extensions.xwiki.org/xwiki/bin/view/Extension/HierarchyMacro ?
> >> >
> >> > If not you might want to find another name since this one already
have
> >> >
https://github.com/xwiki-contrib/macro-hierarchy.
> >> >
> >> > On Wed, May 21, 2014 at 5:23 PM, Lyes Bandou
> >> > wrote:
> >> > > Hello devs,
> >> > >
> >> > > I would like a repository for the Hierarchy Macro on
> >> > > https://github.com/xwiki-contrib.
> >> > >
> >> > > Hierarchy Macro use jQuery and jsTree (http://www.jstree.com)
to
display
>> > > dynamique tree view of wiki documents based on parent/child
relationships
>> > >
>> > > Thank you in advance.
>> > >
>> > >
>> > > Lyes Bandou
>
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
> http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs