20 Apr
2009
20 Apr
'09
11:50 a.m.
Jerome Velociter wrote:
Agreed, I'll update the code today.
This should go in a best practices document on xwiki.org.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
Hi Sergiu,
sdumitriu (SVN) wrote:
The images will need to be saved again to look better. Initially they
were PNGs with alpha transparency and some of them looked bad in IE6
(gray background). I quickly saved them as indexed PNGs with boolean
transparency, and they ended up a bit chunky. I'll have to save them
again as non-indexed images with the right background.
Anyway, if you have a better idea for the rights icon, feel free to
propose it, it was hard enough to find some small icons that look good
and consistent.
Author: sdumitriu
Date: 2009-04-19 21:40:15 +0200 (Sun, 19 Apr 2009)
New Revision: 18827
Added:
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/boolean.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/calendar.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/database.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/groups.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/move.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/number.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/password.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/propertyType-Generic.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/rights.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/staticlist.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/string.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/textarea.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/tree.png
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/users.png
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/dataeditors/
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/dataeditors/dataeditors.css
platform/web/trunk/standard/src/main/webapp/resources/js/xwiki/dataeditors/dataeditors.js
Modified:
platform/web/trunk/standard/src/main/webapp/templates/editclass.vm
platform/web/trunk/standard/src/main/webapp/templates/editobject.vm
platform/web/trunk/standard/src/main/webapp/templates/editpanelsvars.vm
Log:
XWIKI-3635: Improve the object and class editors
Done. L10N will be done afterwards.
[snip]
Property changes on:
platform/web/trunk/standard/src/main/webapp/resources/icons/datamodel/rights.png
___________________________________________________________________
Name: svn:mime-type
+ image/png
This image is not very comprehensive. I had to look twice before getting
it is key ring.
+XWiki.XPropertyOrdering = Class.create({
Shouldn't this be namespaced under the XWiki namespace ?
For example "XWiki.dataeditor.XPropertyOrdering"
If we do not make submodules in the XWiki objects, we'll make the same
mistake we did with the window object, and we will end up with a large
collection of properties and functions that have nothing to do one with
each other.
I'd rather keep the XWiki object for both holding modules and
functions/classes/properties that have sense in all XWiki pages, not
just in one module.