14 Aug
2012
14 Aug
'12
9:18 p.m.
Hi Jerome,
Don't get me wrong, I didn't meant to stop you from making the skin
themeable (if that's what you meant). I just think
that integrating the
theme configuration with the bundled color theme app is likely to be a
wasted effort in the long run, because the app is tied to colibri and
doesn't offer a mechanism to support skin-specific configurations. (like
would be for xorange "sidebar length", or breakpoints properties etc.)
Making it themeable is great :)
At the present moment it is completely theme-able in terms of the colors.
If you change the skin to use the mint app for example, it
will definitely change the feel of the skin as it will use the colors based
on the colors in the mint app. I put in enough effort that it should like
the color themes are meant for the xorange skin.
Do you think it's a good idea to try and create a configuration page that
allows the change of xorange specific properties such as the breakpoint for
the media queries?
I have added the print styling, and at the moment looking for more areas of
improvements. Let me know if you have any improvement ideas everyone.
Thanks all!
Jonathan Solichin
On Thu, Aug 9, 2012 at 1:47 AM, Jonathan Solichin <jssolichin(a)gmail.com>wrote;wrote:
In that case the right solution would be to extend the
color theme
mechanism in order for it to offer the additional
values you need, not
adding a new configuration page :-)
I'm not so sure about that. Extending the official color theme
application is going to be a PITA for maintenance
over the long term for
any skin not bundled and supported by the XWiki dev team.
It's one thing to use the color theme mechanism for preferences storage
of new skin-specific properties (but even that in my opinion doesn't
worth it) ; but extending the UI for managing those preferences is
another and I don't see that a viable solution right now.
Ok thank you for the thoughts. As per these advice, I will stop that plan.
The skin works and looks fine without it. I just thought it might be
interesting to add, but it is in no way unnecessary.
Not final, but this is what I'm heading towards :
http://i.imgur.com/RSguA.png. The right part will
behave just as xorange
sidebar in terms of responsiveness, so this is where deriving xorange
will be interesting.
It seems that the primary focus to keep is the sidebar? correct me if I am
wrong on this.
I went ahead an tried an attempt to separate. If you pull from github now,
there will be a style.css (core), an xwiki.css (the extension), and a new
src folder that has the two css line by line where it is divided. The first
line of style.css is @import to xwiki.css, so if you wish to not pull the
additional styling, you can just comment this line out (should i make a
configuration page that does this, or is this too trivial?)
The way i went about the dividing was to try and cut out all the
typography, padding/margin and etc. I left behind some of the style intact
because I felt like they were pretty integral to how the skin works. Eg.
the sidebar is almost completely untouch, and the dropdown is left in. Let
me know what you think of this division, and whether I should try to
separate more.
Thanks!
Jonathan Solichin
On Tue, Aug 7, 2012 at 11:38 AM, Jonathan Solichin <jssolichin(a)gmail.com>wrote;wrote:
Hi Guillaume,
Thanks for dropping by. You are right, the feature is part of XWiki;
the skin is just now implemented to take advantage of it.
The reason I wanted to create a specific configuration page for the skin
on top of this is because some of the features/color styling that are in
the original skin are not part of XWiki's color theme. Eg. rgba color
coding (allows for changes in opacity), and h1-h6 color differentiation
etc. Some of the color themes available through xwiki are not very relevant
to the skin either. Eg. Gradients and so forth.
The other option is to use all the colors on XWiki color theme, but it
might not be named correctly (eg. using button's 2nd gradient color as the
color for h4).
Let me know if that sort of addresses your concern, or whether you still
think there is a better way to go about this.
Thanks again!
Jonathan Solichin
On Tue, Aug 7, 2012 at 1:21 AM, Jonathan Solichin <jssolichin(a)gmail.com>wrote;wrote:
Hello friends,
I just updated the skin to allow the use of xwiki built in color themes.
My plan is to have a settings page that allows you to use xwiki color
themes, or use a preset color theme specifically made for xorange (eg. the
original one + maybe a couple more).
Beside this major change, most of the fixes mentioned earlier are
implemented (eg. blog skin and other miscellaneous fixes/skin improvements
(js, responsiveness etc.)).
I am still working on separating the core skin with the extra portion.
I'm still not sure of what part people might change, so I don't know where
I should draw the line. Any thoughts on this would be appreciated.
Thanks again everyone,
Jonathan Solichin
On Thu, Aug 2, 2012 at 1:29 AM, Jonathan Solichin <jssolichin(a)gmail.com>wrote;wrote:
Hello friends,
Beside yesterday's addition, these have also been addressed. I
apologize if you checked yesterday and the addition was not on github/live
instance, I uploaded the unchanged folder.
- Lots of sections in Administration are missing the styles + some
> portion
> of settings are displayed after the administration menu ends (Chrome)
> (you
> need to scroll in order to see all the options, see Administration ->
> Applications -> WYSIWYG Editor settings )
- .xform style for .xHint are gone (you can observe this when creating
> pages/spaces)
I just uploaded some stylings that makes this more eye pleasing and
responsive.
- The page -> Share by email feature is style-less.
Styled this as well
Thank you,
Jonathan Solichin