[xwiki-devs] Inconsistency between Flamingo Skin and Icon Theme Application

Hello there. Flamingo is a skin based on Bootstrap, and this framework offers a free but reduced set of icons [1] coming from Glyphicons.com [2]. For this reason, when I started the implementation of Flamingo, I used the free Glyphicons from Bootstrap. A few months later, we introduced the Icon Theme Application [3], in order to replace our Silk icons [4] by more accurate ones, depending on the configuration of the wiki. Unfortunately, the icons provided by Bootstrap were not a good candidate to replace Silk, because a lot of icons were missing. Instead, we have decided to use Font Awesome [5], which looks more like Glyphicons. However, we haven't changed Flamingo to drop glyphicon, so we have an inconsistency between what we propose to developers via the Icon Theme Application, and what we have in the skin. It means a developer cannot, using our best practices, re-use the same icons that the normal UI. So the only option I see is to use the Icon Theme Application in Flamingo too. We have an issue for this [6]. But it means: - Flamingo won't look good if the Font Awesome Theme is not installed on the wiki - It's a matter of taste or habit, but I think Font Awesome does not look as good than Glyphicons in the skin. See: -- http://jira.xwiki.org/secure/attachment/33143/mockup.png -- http://jira.xwiki.org/secure/attachment/33144/mockup-drawer.png - Some Velocity macros [7] (that might be used by extensions) expect to work with Glyphicons. By changing this we create a breaking change. I am not satisfied with the first results. It may be improved, but keep in mind that every changes that we made in the XWiki Icon Set affect all Icon Themes (Font Awesome and Silk). What do you think ? Thanks, Guillaume [1] http://getbootstrap.com/components/#glyphicons [2] http://glyphicons.com/ [3] http://extensions.xwiki.org/xwiki/bin/view/Extension/Icon+Theme+Application [4] http://www.famfamfam.com/lab/icons/silk/ [5] http://fontawesome.io/ [6] http://jira.xwiki.org/browse/XWIKI-12595 [7] For example https://github.com/xwiki/xwiki-platform/blob/76ff57ec6a6fca48bc5f3f563f575b… used by http://platform.xwiki.org/xwiki/bin/view/ExtensionPoint/Edit+Actions -- Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project