12 Nov
2008
12 Nov
'08
6:26 p.m.
On Nov 12, 2008, at 6:00 PM, Thomas Mortagne wrote:
I would prefer follow the java package style.
That's a decision we need to take but IMO it doesn't have to follow
the same rule.
My preference goes with an 's' for directory names since it's more
clear that it contains several sub modules. With no "s" you're in
doubt and need to check inside.
[snip]
Thanks
-Vincent
On Wed, Nov 12, 2008 at 5:59 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
> On Wed, Nov 12, 2008 at 5:39 PM, Vincent Massol
> <vincent(a)massol.net> wrote:
>>
>> On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
>>
>>> Hi devs,
>>>
>>> the xwiki-core-rendering module is growing more and more and will
>>> contain too many things and dependencies IMO.
>>>
>>> For example I will soon commit code macro and script/groovy macros
>>> which come with big dependencies (like jython, groovy, etc.) and it
>>> would be god to not add more things in already too big core -
>>> rendering
>>> pom.xml file ;)
>>>
>>> Now the proposal: add a xwiki-macro submodule in /platform/core and
>>> have one macro/one sub module (xwiki-macro/xwiki-macro-code,
>>> xwiki-macro/xwiki-macro-script, etc.).
>>
>> +1 but with the following conditions:
>>
>> 1) named xwiki-macros (note the 's' since this is how we've named
>> other modules like plugins, applications, xwiki-containers, etc)
>
> xwiki-query and xwiki-cache does not contains "s"
That's because they haven't been following the practice I started ;)
> and xwiki-containers
> sub modules are named xwiki-container-* so I think there is a
> problem....
No that's perfectly normal and done voluntarily. The plural is only
when there's more than one. The sub module do not have an 's' because
they're not hosting several containers.