On Jul 9, 2007, at 10:16 AM, tharindu jayasuriya wrote:
Hi Vincent,
On 7/8/07, Vincent Massol <vincent(a)massol.net> wrote:
Hi Tharindu/Asiri,
* I have now created a separate JIRA project for the Eclipse
integration and I have moved the issues there:
http://jira.xwiki.org/jira/browse/XECLIPSE?
report=com.atlassian.jira.plugin.system.project:roadmap-panel
This is fine with us.
* I have also separated some issues into several issues so that
it's easy to close them separately.
* I have created 3 versions for the release of this project:
- 1.0M1 (milestone 1) to be released on 13th of July 2007
It's better if we can move this to 15th of july since we (myself
and Asiri) have a tight academic schedule this week (close to mid-
semester exams)
Done.
- 1.0M2 (milestone 2) to be released on 6th of August 2007
- 1.0 (final release of your GSOC project) to be released on 20th
of August 2007. This last release shouldn't contain any JIRA
issues. It's meant that 1.0M2 is going to be promoted as 1.0 final
if there are no outstanding bugs in it. If there are then we'll
create a 1.0RC1 version at that time.
* I have created an issue for you to clean up the code and apply
XWiki's best practiced (coding style, javadoc, etc).
http://jira.xwiki.org/jira/browse/XECLIPSE-11
Immediate Actions for you:
* Review the above and let me know if all is ok with you,
especially in term of dates. I have also assigned issues XECLIPSE-2
and XECLIPSE-10 to 1.0M1 but I don't know if that's ok with you or
not. If not please re-assign.
XECLIPSE-2 , and XECLIPSE-10 are ok with us, but please move the
release date to 15th :)
:)
* Clean up the code so that we can commit it in
XWiki's source tree.
We have applied the check-style to our code (which is not a big
deal) but Java doc comments still need to be added.
Will adding JavaDoc comments wrap things up ? or, are there any
other work that need to be done in this regard ?
I'll check the code tomorrow but last time I checked there commented
out portions of code and some classes were prototypes and not used
too (If I remember correctly which may or may not be the case ;)).
Anyway let me check tomorrow (need to do some release today).
We can clean up the code this way by 13th of july, is this ok with
you ? (sorry about taking few days, bit busy...)
That's fine thanks.
* Finish your tasks for 1.0M1 release
Will finish on/before 15th july. But we have a problem regarding
maven build. I think the maven build should produce the final
deployable plug-in-component (jar file) on 'mvn package'. Even
though this target works, the produced jar file have problems when
deployed as an eclipse plug-in. We'll somehow have to figure this
out...
Once the code is checked in in our repository, I can have a look and
work on fixing this.
Thanks
-Vincent
Please let us know if above are ok with you.
Thanks a lot !
- Tharindu & Asiri
Immediate Actions for me:
* Review the code (prereq: you must clean it up first)
* Send a vote to vote Asiri and you as committers on the Eclipse
integration when committed in XWiki's source tree. Note: The prereq
for this is that you clean up the code first.
* Commit the code in XWiki's source tree (prereq: clean up the code)
* Release 1.0M1 (prereqs: commit it in XWiki' source tree and
create M2 build for it)
* Create m2 build for it (prereq: clean up and commit code)
Please answer to this email point by point to let me know your
point of view.
Thanks a lot!
-Vincent
On Jul 7, 2007, at 10:50 PM, Vincent Massol wrote:
> Hi Tharindu/Asiri,
>
> Great job! I think it's time to try integrating your code in our
> source tree and start doing some code review of it to verify it's
> using XWiki's coding best practices.
>
> I propose the following:
> - Tomorrow I create a xwiki-extensions module for xwiki extensions
> and I drop your latest sources (1.0.1) in SVN
> - I start a vote to give both Asiri and you write access to it
> - I create a separate jira project for it
>
> WDYT?
>
> I've started using your plugin and I can already see several
> killer features in the future:
>
> * Defaults to using the Veloedit editor (http:://
>
veloedit.sourceforge.net). When right clicking a document in the
> navigation, there should be an "open with" menu with "Simple
> Editor" (the current editor you have) or "Velocity Editor" (or
> "Groovy Editor" for the future - There's a groovy plugin for
> eclipse).
>
> * Allow navigation directly to a page when hitting a shortcut or
> right-clicking in a internal link in the editor window. This can
> be easily implemented with the DocumentParser and LinkParser
> classes (about 5-10 lines of code)
>
> * Offer a XAR export view in addition to the "print" view in the
> simple editor. Note: before we can do this we need to create a URL
> for this in xwiki platform. This would make it easy to develop new
> pages and save them in XWiki's source tree
>
> Thanks
> -Vincent
>
> On Jul 7, 2007, at 11:48 AM, tharindu jayasuriya wrote:
>
>> We have completed work allocated for Milestone-2 of XWiki-Eclipse-
>> Plugin (+ more).
>>
>>
http://jira.xwiki.org/jira/browse/XWIKI-1361
>>
>> Implemented Features:
>>
>> - view existing pages (as xwiki markup or browser output)
>> - edit xwiki markup (using TextEditor widget in eclipse)
>> - save edited content
>>
>> Although we encountered some problems as well,
>>
>> - We couldn't prepare the pom.xml file such that maven produces a
>> deployable plugin component. Eclipse needs the plugin jar file to
>> have a specific format and maven enforces a different format,
>> we're still struggling to get it right (need some help). Although
>> compilation and other stuff or quite ok.
>>
>> - Eventhough the edited XWiki Markup can be saved, the output(in
>> browser) does not reflect changes untill we restart XWiki. Is
>> there a way to forcefully flush the cache ? can this be done
>> remotely ?
>>
>> All comments are welcome!
>>
>> Thanks a lot!!!
>>
>> - Tharindu & Asiri