Re: [xwiki-devs] [Proposal] Change script macro to return JSR223's eval value

Hi devs, I’ve implemented http://jira.xwiki.org/browse/XWIKI-11961 However it’s causing several tests to fail, proving that it’s changing the script behaviors. For example if you have: {{groovy}} var = "toto" {{/groovy}} {{velocity}} $var {{/velocity}} Then you’ll see “toto” printed twice. Once for the groovy macro. The right way to not output content is to use output=false as in: {{groovy output="false"}} var = "toto" {{/groovy}} {{velocity}} $var {{/velocity}} So we need to decide if we’re ok to go with this even though it changes the behavior. I don’t completely master the full gamut of consequences this will have but I have the feeling that from a logical point of view, it’s the best thing to have. WDYT? Thanks -Vincent _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs