Thomas Mortagne wrote:
Hi devs,
The real full qualified name of a document is wiki:Space.Page. I think
we sould always use only this form for technical purposes like storing
in database or old API which does not support DocumentName.
pros:
- don't need to take care of the context, the information is always right.
- if everything is stored in only one form it's way easier to compare
things and do requests
cons:
- old code which does not support this document name form will fail.
This could hardly be a good arguments since this form is a officially
valid document name but i can't see anything else.
Among others, the last use case which make me send this proposal is
http://jira.xwiki.org/jira/browse/XWIKI-3754. IMO getLinkedPages
return and the link table should only contains fully qualified links,
especially since theses lists are supposed to contains uniques
documents and we need to know the 3 parts of the document name to make
sure of that . Note that a document could contain a link to a document
in another wiki or even a link to the same document but written in its
full form so a code which support only local form is wrong anyway.
WDYT ?
+1, 1.9 looks like a good place to break the old behaviour.
although for a single wiki (non-multiwiki environment) this full form will
always be a little too much, since the wiki prefix is redundant.
Also, I think the doc.fullName should be consistent with this (ftm it seems to
return Space.Page).
Happy coding,
Anca
Here is my +1. The pros are basically the same that make us introduce
DocumentName to not manipulate String anymore in code.
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs