16 Apr
2010
16 Apr
'10
9:36 a.m.
Well, I agree with all of you but my feeling is that current file exclusion
is worse than using these comment in the source code. Since we monitor
anyway what is committed, and that we may define correct practice for the
usage of these exclusion, I am +1 to use them in old code file
(non-component code).
Denis
On Fri, Apr 16, 2010 at 02:49, Caleb James DeLisle <calebdelisle(a)lavabit.com
wrote:
Vincent Massol wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Denis Gervalle
SOFTEC sa - CEO
eGuilde sarl - CTO
On Apr 15, 2010, at 12:56 PM, Sergiu Dumitriu
wrote:
> On 04/15/2010 12:55 PM, Caleb James DeLisle wrote:
>> I would like to propose changing checkstyle.xml to allow checkstyle to
be
enabled and disabled
>> using inline comments. I propose this
with some reservation because
this can be a slippery slope
>> but I would rather see the problems
isolated in the file than the file
excluded.
>> Also I think this can be used to enforce
checkstyle on changes made to
code in big files in
>> the old core.
> I don't like it very much, since it adds non-code elements in the source
> file. A source file should contain as little languages as possible, and
> we already have Java + Javadoc + HTML + English comments
+ a few different
types of annotations + remnants of aspectj in some places
(?).
> , adding checkstyle config would be too much.
I'm not sure I would call CHECKSTYLE:ON and CHECKSTYLE:OFF configuration.
Also I would want to define
a best practice that it only be used in legacy code.
I agree with Sergiu.
Thanks
-Vincent
> Can't the error be solved in other ways? What exactly is the problem?
I
had planned to use it for fixing most of mailsender api while excluding a
method which has too many
parameters but changing it would be an api break. I could also see
applications when code is added to
the old core such as XWiki.java and XWikiDocument.java.
I'm not disappointed to see this shot down, introducing tools which make it
easier to write dirty code
was something I had some reservations about from the beginning.
Caleb
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs