2 Aug
2010
2 Aug
'10
5:54 p.m.
Marius Dumitru Florea writes:
IIUC it is better to get to the actual job (for what I have installed
X-Wiki) done, and return to the issue when default labels will be
supported. I've managed to get through every obstacle. "Enter" and
"improve" GWT wizards is about beauty. It is not a blocker.
I'd better implement JavaScript enhancers for magnet links. They will
enhance magnet links with rolldown menu giving several options like
"bbCode", "HTML", "wiki", etc.
But it is not obvious how to achieve this.
I've tweaked GWT editor
to allow empty labels in magnet links, but such links look empty in
WYSIWIG and are being deleted on save.
Indeed, empty anchors are removed in a cleaning filter on the server
side, before the content is converted to wiki syntax. I think we need a
new method in the WikiService to retrieve the default link label for a
given link type. The insert/edit link wizards will then query the server
for the default link label when the user leaves the label input empty.
The default link label must not be hard-coded in the
WYSIWYG editor
since it is need also when rendering the page in view mode. The
rendering module should have control on the default link label and
should allow administrators to configure it. There is something
already implemented but only for wiki page links (look for
"rendering.linkLabelFormat" in xwiki.properties file).
Also, note that the rendering module generates a specific link meta
data when the link label was automatically generated:
It is implemented already in the rendering module. Freestanding magnet
links are being recognized and displayed properly. [[magnet:?something]]
links work as well.
P.S.: If you have any patches to the WYSIWYG editor
don't hesitate to
attach them to a JIRA issue and I'll try to commit them asap.
OK. I am going to comment out second wizard step and make the first step
look like email and external web page wizard. "Improve" step is of
little use when label and link are not synchronized.
--
If you want to get to the top, you have to start at the bottom