Re: [xwiki-devs] [GSoC] Responsive Skin

Hello friends, You could re-write the whole macro in your template (as a macro - or not). Ah, so I only need to write in the macros i specifically need in my macros.vm (that is, my macros.vm will not overwrite the template macros.vm, but will load on top of it?). I tested this and deleted all the macros except the one I changed, and it seems to be working. However, I wanted to make sure, since macros.vm is a big file and that I am not messing anything up. Thanks for the tip. I realized that there is a bug in the skin that prevented some pages from being displayed correctly, or being redirected incorrectly. Those pages would redirect to "[correct url]?viewer=comments" and I realized it was because of the way the commentsinline.vm is integrated into the skin. If my attempt to solve the bug and understanding of xwiki is correct, this is a result of the redirectIfActionNotView macro. Specifically, I think that "#if(!$requestedByAjax && $xcontext.getAction() != 'view' && $xcontext.getAction() != 'get')" on line 85 of commentsinline.vm is causing the redirect issue because the comments are no longer being requested by ajax in my skin (it loads everything and the skin just scrolls to the correct place). This seems to be confirmed as if I remove the ! in front of $requestedByAjax, the document would show up correctly. However, this does not seem to be the correct solution, since if I do this, the page won't be refreshed if I add a comment (manually refreshing the page reveals that the comment has been successfully added). I tried deleting $requestedByAjax and permutting different conditions to load this correctly, but to no avail. Can you point me in the right direction for an elegant solution at this? Also, I am planning to make the livetables work responsively (since they are an integral part of xwiki, and it seems to break the responsiveness of the skin). Presently, my research is pointing me to this solution: http://filamentgroup.com/lab/responsive_design_approach_for_complex_multico…. What are your thoughts/comments? Finally, this was sort of brought up in the semantics thread, but I was wondering whether I should also skin applications (eg. blog)? If I understand correctly, the skin files do not touch upon them? Actually, I guess the css will. Should I just skin them through css, or should I do more? Thank you again!