26 Nov
2014
26 Nov
'14
2:57 p.m.
I'm +1 for Contributor (if the PR is complete).
Is kind of the committer's job to do the PR review and although this is
hard work :) encouraging the contributor in making more PRs and maybe then
voting him as committer is a nice strategy.
We can always see in the Commits tab who did the merge.
Thanks,
Caty
On Wed, Nov 26, 2014 at 3:44 PM, Jean SIMARD <jean.simard(a)xwiki.com> wrote:
+0
On Wed, Nov 26, 2014 at 03:21:06PM +0200, Ecaterina Moraru (Valica) wrote:
Hi,
We have discussed this subject multiple times, but we don't have an
official vote and conclusion on the topic.
Problem: In JIRA who is the Assignee of an issue fixed by a Pull Request?
1: Contributor
- he provided the solution
- giving the attributions, the contributor might feel encouraged to
contribute more
- we could do some JIRA statistics on external contributions, but this
use
case can be covered by GitHub statistics
2: Committer
- he does the merging on his account and he becomes responsible for the
committed code.
- in case there are problems, the committer needs to find solution, since
we can't rely on contributors availability
- in doing the PR review, the committer spends a lot of time analyzing
and
testing the provided solution
We are talking here about complete solutions provided by the PR, since in
case of partial solutions, the committer can assign himself on the issue
(depends on the quantity of modification he does).
Let me know what you think,
Caty
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Jean Simard
jean.simard(a)xwiki.com
Research engineer at XWiki SAS
http://www.xwiki.com
Committer on the XWiki.org project
http://www.xwiki.org
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs