6 May
2008
6 May
'08
1:17 a.m.
Hi Sergiu,
On May 5, 2008, at 7:59 PM, sdumitriu (SVN) wrote:
Author: sdumitriu
Date: 2008-05-05 19:59:18 +0200 (Mon, 05 May 2008)
New Revision: 9649
Modified:
xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
XWiki.java
Log:
[misc] Fix NPE during tests
Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/
xwiki/XWiki.java
===================================================================
--- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
XWiki.java 2008-05-05 16:57:49 UTC (rev 9648)
+++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/
XWiki.java 2008-05-05 17:59:18 UTC (rev 9649)
@@ -3580,7 +3580,9 @@
// doc.getOriginalDocument()
ObservationManager om =
(ObservationManager)
Utils.getComponent(ObservationManager.ROLE, null, context);
- om.notify(new DocumentDeleteEvent(doc.getFullName()),
doc, context);
+ if (om != null) {
+ om.notify(new
DocumentDeleteEvent(doc.getFullName()), doc, context);
+ }
Question: Utils.getComponents throws a RuntimeException when a
component cannot be found. Thus I'm not sure why you're testing for
null? Am I missing something?
In addition I think that if we really wanted to test for null then we
should also have an else and display a warning if a notification
cannot be sent. However I don't think it's normal that such a
component cannot be lookup and we can safely assume it is found. The
test should probably be modified to use AbstractXWikiComponentTestCase.
WDYT?
Thanks
-Vincent