16 Apr
2007
16 Apr
'07
4:45 p.m.
On Apr 16, 2007, at 4:33 PM, Vincent Massol wrote:
On Apr 16, 2007, at 10:32 AM, Ludovic Dubost wrote:
[snip]
The reason I did not propose XClass is because even though we've
agree to use this name when we talk about it, this is not a name
currently used in the code and introducing a new concept in only
one place in the code is, I think, a bad idea.
I'd rather call it getXWikiClass() or getDocumentClass() which
sounds better as more descriptive.
WDYT?
I'm changing my mind. I've just realized this method is not hiding
the Object.getClass() one as the signatures are different. Also
there's already a com.xpn.xwiki.XWiki.getClass(...) method. Thus I
propose to keep the getClass(...) name for now...
Sorry for the noise...
-Vincent
2)
You've added a new getClass API in api.XWiki:
2.1) There's no JIRA issue for this and that's important for
end users
2.2) The method name is not good I think as it hides the
Object.getClass() method and in any case is confusing. I would
suggest getDocumentClass()
2.3) It seems to me this method should be on the Document
class rather than on the XWiki class, no?
The purpose of this function is to
access directly to the XClass
(new name) object bypassing all rights. This was need to be able
to show the register page without being blocked by rights on the
XWiki.XWikiUsers page. It should not be in the Document class (it
already exists there (getxWikiClass) since it would be blocked by
rights. I didn't thought of the getClass conflict.. We can call it
getXClass. If you do it don't forget to modify registerinline.vm
since there is a call there.