On Mon, Aug 22, 2011 at 10:39 PM, Thomas Mortagne <thomas.mortagne(a)xwiki.com
wrote:
> On Mon, Aug 22, 2011 at 12:56 AM, Chamika Weerasinghe
> <chamikaw(a)gmail.com
wrote:
> > On
Sat, Aug 20, 2011 at 9:31 PM, Thomas Mortagne
> > <thomas.mortagne(a)xwiki.com>wrote;wrote:
> >
> >> On Sat, Aug 20, 2011 at 12:56 AM, Chamika Weerasinghe
> >> <chamikaw(a)gmail.com
wrote:
> >> > On Fri, Aug 19, 2011 at 1:03 PM, Thomas Mortagne
> >> > <thomas.mortagne(a)xwiki.com>wrote;wrote:
> >> >
> >> >> Hi Chamika,
> >> >>
> >> >> On Fri, Aug 19, 2011 at 5:56 AM, Chamika Weerasinghe <
> >> chamikaw(a)gmail.com>
> >> >
wrote:
> >>
>> > Hi all,
> >> >> >
> >> >> > I've finished development of the XWiki Android Client. I
also
> finished
> >> >> XWiki
> >> >> > REST library unit tests and instrumentation tests for the UI
> >> components
> >> >> will
> >> >> > be added soon.
> >> >> >
> >> >> > Here is a demo of the application.(This demo is captured using
the
> >> >> Android
> >> >> > emulator which may result slow response than an actual
device)
> >> >> > (
http://www.youtube.com/watch?v=aiEM0iNMnTE )
> >> >> >
> >> >> > Please give me your feedback so that I can improve the
project.
> >> >>
> >> >> Very nice video !
> >> >>
> >> >> Here is what seems to be missing before a first release IMO:
> >> >> * I can see an object viewer but no class viewer
> >> >>
> >> > Since classes list of a wiki is very large, everytime UI fails to
> load.
> >> > Therefore I avoided putting it. Library works fine.
> >>
> >> Listing classes is one thing but what I'm actually talking about is
> >> having a third tab when you edit a document to edit just the class
> >> stored in this document like you can edit the objects stored in that
> >> document. For example in XWiki standard UI when you edit a document
> >> you can have several editors: wiki, wysiwyg, objects, class, rights.
> >>
> >
> > If you are asking for class editor, I think it doesn't provide with XWiki
> > REST (
http://platform.xwiki.org/xwiki/bin/view/Features/XWikiRESTfulAPI
> ).
> > There is no PUT or POST method support for adding properties to a class.
>
> I can see on
>
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwi…
> some xclass related server REST resources, maybe the documentation is
> not up to date.
>
I checked the java class files in the given source. But I couldn't see any
method which implements @PUT or @POST in ClassResources. If they have
already implemented it, can you give me the information about it?
Since you are asking for a 3rd tab for classes, I developed a view for
showing list of classes used in that page and properties of the classes
can
be *viewed*.
Again I'm not talking about viewer/object editor but class
viewer/editor. The tab I'm talking about should display the class of
the document and not the class used by objects of this document.
Since many components are already developed it's not a very big deal to view
the class of the document.I'll change it as you preferred.
But editing cannot be implemented because REST doesn't have that. same
problem mentioned above.
About the issue you have here you could have the exact same with pages
and even objects, maybe you could add some pagination in your UI to
not load everything at once.
I hope to improve additional features like these after GSOC is over. As I
said I'll contribute to this project continuously.
>
> >
> > * the UI does not allow to edit (except for attachment and comments)
> >> but does the library allows it ?
> >>
> > Yes library allows it. I added editing content using object selection
in
> my
> > recent push. This component was developed early but have some issues.
Now
> > it's working fine. Go to object View
and select an object to edit the
> > content.
> >
> >
> >> * did you had time to implement some caching ? even if you don't have
> >> edition yet would still be nice to cache some pages and check behind
> >> the scene if the current page changed on server to avoid
> >> re-downloading it when you go to page1 then page2 and then go back to
> >> page 1.
> >>
> > Sometimes I used caching but there are many places which will improve
the
> > performance by caching. Sorry I'm
little bit busy these days and
couldn't
> > find time to do that. I will surely
improve caching later.
> >
> >
> >> * is https supported ?
> >>
> > Since you are not advised me to look into https I didn't setup https
> classes
> > yet. But https is possilbe in Android development.
>
> Since supporting https is trivial in Java I did not expected it to be
> a lot more work actually.
>
> >
> >
> >> * in the setup I see you have only the host/port as server
> >> information, as we discussed some time ago I think it would be better
> >> to let the user put the full base URL (
http://host:port/xwiki/rest/)
> >> of the REST service (but you can have a wysard to help generate the
> >> URL), that's because some part of the URL can be changed by
> >> configuration and it also answer my previous question about https I
> >> guess
> >> * is it too big for the GSOC to have the server setting part as an
> >> Android account ? would be super nice since it would allow several
> >> application to use the same account to access a wiki. At worst if you
> >> looked at it it would be nice to put what you found some far in a
> >>
http://dev.xwiki.org/xwiki/bin/view/Design/ page and same note for
any
> >> other TODO you have in mind that you
could not finish
> >>
> > I think there is no time left to work in GSOC. But I like to
contribute
> > XWiki Android continuously. I'll get
more free time after my
internship
ends( will take another three/four weeks). Then
I'll work on this.
That would be great !
>
> Some suggestions for the demo:
> * would probably be nicer to do the demo with a well known wiki like
>
xwiki.org or
myxwiki.org
I'll give a demo using one.
New demo uses page accession to
www.xwiki.org
Here is the new demo (
http://www.youtube.com/watch?v=TOvuBygvZMU )
>
>
> Did not had much time to look at the code of the library yet but will
> sure do next Monday.
>
It's ok :)
>
> I can see on
http://maven.xwiki.org/snapshots/org/xwiki/android/that
> you have xwiki-rest-gson-model, xwiki-rest-model-simplexml and
> xwiki-rest-simplexml-model so which one is teh right form ? As I told
> you already I think you should have
>
> - xwiki-rest-model
> -- xwiki-rest-model-gson
> -- xwiki-rest-model-simplexml
>
As you said I
renamed xwiki-rest-simplexml-model to xwiki-rest-model-simplexml. I
didn't
touch the gson model lately. So no changes are
made to gson model.
That's not exactly what I said: xwiki-rest-model should be pom
artifact with the two others as sub projects. The goal of my proposal
being to regroup the different models just renaming one of them is not
very useful ;)
Changed the model of the modules.
>
> >
> > Thank you,
> > Best Regards,
> > Chamika Weerasinghe
> > _______________________________________________
> > devs mailing list
> > devs(a)xwiki.org
> >
http://lists.xwiki.org/mailman/listinfo/devs
> >
>
>
>
> --
> Thomas Mortagne
> _______________________________________________
> devs mailing list
> devs(a)xwiki.org
>
http://lists.xwiki.org/mailman/listinfo/devs
>
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Best Regards,
Chamika Weerasinghe
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Best Regards,
Chamika Weerasinghe