7 Jun
2019
7 Jun
'19
7:20 p.m.
Hi,
Thanks for the PR Stephane! It really helps in knowing how I should do
things.
I will accept the PR now and make changes later if required. I tested it
and everything seems fine so far except for some country facets the map
goes blank (bad data handling on my part maybe).
Hoping such sample data can help developing further and think in greater
details about real case scenarios.
It helps a lot, thanks.
When displaying such a map, that'd be great if the available facets would
get displayed directly, without the need to enter a
query in the input
field (you probably have this in mind already as well).
This has been done and will be included in today's commit.
I was actually writing my custom solr configurations for the map. Now that
I know a use case, I can include better options.
Best,
Fawad
On Fri, Jun 7, 2019 at 9:59 PM Stéphane Laurière <slauriere(a)xwiki.com>
wrote:
Fawad, Caty, all,
I have a short comment about the tests:
Hi Caty,
Thanks for the review.
Maps/MapTesting/Maps/TestMap - I find it strange that the Maps space
is
duplicated
This space exists only for testing. It won't be there for the real
application. I named them so that its easier to know which type of object
pages are located in them (for myself).
MapTesting, Maps, Points - spaces don't have homepages. The users
will
navigate to them, since they are present in breadcrumb. So what is the
plan? Simpler paths? or create Homepages for these types of entry?
Since we are in the beta stage now, the whole MapTesting space exists
for testing
for developers. It would not be there once we have a stable
version ready for release.
Actually this raises a question, all the more as we also discussed the
importance of having automated functional tests earlier today on #xwiki
with Vincent. For automated testing, we will need sample data, and I'm
wondering where we should store this sample data (and possible scripts or
code for obtaining it). How do other projects deal with test data in such a
context? Is the test data stored in the same repository or in a distinct
one? I was looking for some Solr application test data but could not find
it yet. Note that we may consider the testing area as a set of demos
instead in some way, couldn't we? It would make sense to keep it (just like
if it's real test data), and to provide a navigation across these pages as
you suggest it, Caty.
Cheers
Stéphane
Lots of pages that are not hidden. All
technical pages needs to be
hidden.
Again, these pages are not technical and exist only for testing purposes.
A bit confusing that there are 2 search boxes for the maps, see
https://up1.xwikisas.com/#XngcOAZexsKE4DryH2i6zA
Yes, thanks for pointing out. We need to move the search function
directly
inside the map. I will look into it once I am done with the facets.
For the search input, its in extremely beta
stage. I am still trying
to figure out the macros I have borrowed from
SolrSearchMacros. So it will
take time for me to make a more stable version of the facets. I hope I can
do that in due time. :)
Regarding the facets, we need some more user friendly translations
and
customizations for this kind of UI, see
https://up1.xwikisas.com/#TYj_9oLn84Mfp87VnwNgkw
As discussed earlier with Stephane, we are still having issues using the
normal
$facetDisplayer so we are using a workaround for testing purposes
that's why it looks like this. More precisely, we are using
the #displaySearchFacetValues($facetValues) macro for now.
Best,
Fawad