31 Jul
2012
31 Jul
'12
11:57 p.m.
On 07/31/2012 04:54 PM, Ecaterina Moraru (Valica) wrote:
Hi Jonathan,
Regarding the Skin testing - one solution would be to test it on incubator (
http://incubator.myxwiki.org/) as long as you don't broke everything there
(especially the Improvements space) :) but I guess a skin should be
harmless, right? ;)
Now some problems:
After I logged in I really don't know what button to press in order to edit
the Main.WebHome.
Regarding the buttons (Preview, Save&View, Save&Continue, etc.), I see that
you choose to align them right. Our standard is vertical-aligned-left
http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms
I notice this on login page and on editing pages. This is easily fixable
from CSS (.buttons class).
I think this ought to be skin specific. I take the standard as for the
officially maintained XE skin, a.k.a. colibri ; and think it would be
fair to say other skins could derive from it.
That said, I have a personnal preference for left-aligned or centered
buttons.
You stripped all the CSS, so there will be lots of problems in lots of
places. Maybe you should put back all the style dependencies.
I think Jonathan took inspiration from me on this one, this is what I've
done in Lyrebird.
To be honest, I think that pulling all style dependencies for
implementing a new skin is at least as hard as rewritting them all. Lots
of "component styles" (ex. search suggest, livetable, etc.) are in
reality tied to the visual codes of colibri (and sometimes even the
selectors are tied to colibri), and don't work well outside this scope.
The long term solution would be to have documented CSS components (a la
bootstrap for example) and DOM breakpoints (i.e. #mainContentArea, etc.
- this would also be useful in the event we implement generic interface
extensions as they were initially planned).
Now, there are some styles that could be pulled or copied over from
colibri. {{code}} macro styles are one example, but I'm sure there are
others.
- You don't have any style for error boxes (
http://23.21.87.183:8080/xwiki/bin/view/XWiki/OfficeImporter?&parent=XW…)min).
The style for info is not noticeable enough(looks very similar to table
headers). The style used for warning is better suited for error macro.
- The page -> Share by email feature is style-less.
Could it be because the app SSX has CSS selectors that don't match with
xorange DOM ?
- .xform style for .xHint are gone (you can observe
this when creating
pages/spaces)
- Administration -> ColorThemes can't be edited anymore in inline mode (the
JS doesn't work)
- Administration -> Panel Wizard is broken too
- Administration -> Users, Groups (adding, editing, deleting users/groups)
doesn't work
JS issue ? I think JSX are puled by xorange. Maybe there is a
conflict
with other JS code from xorange...
- Lots of sections in Administration are missing the
styles + some portion
of settings are displayed after the administration menu ends (Chrome) (you
need to scroll in order to see all the options, see Administration ->
Applications -> WYSIWYG Editor settings )
Same remark as for share by email
- Problems with Blog posts in view and edit modes
- Pages with few content look kind of strange :)
http://23.21.87.183:8080/xwiki/bin/view/Sandbox/TestPage2 or
http://23.21.87.183:8080/xwiki/bin/view/Main/CC
- Some more left-right margins on content would be nice (looks crowded).
25px+ would work better than 10px margins on #xo-content
- I like the Administration breadcrumb :p
- I like how some forms look in edit mode :) like editing the Profile,
although there are some issues with the sections H1
Restyling the whole wiki is a big task and there are lots of things to do,
but until now looks great.
It sure is :)
Thanks for your input Caty, very insightful.
Jerome
Thanks for your work,
Caty
On Tue, Jul 31, 2012 at 11:52 AM, Jerome Velociter <jerome(a)velociter.fr>wrote;wrote:
--
Peace,
—Jerome
On 07/30/2012 10:09 PM, Jonathan Solichin wrote:
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs I think that's a great idea, it would make
the skin more extensible. Right
now I am exploring creating a xar to create a page where there can be
options-- right now for the colors, like you did with the "fluid" option
on
lyrebird.
As I am separating the codes, i am wondering how far i should separate the
core? Should i just leave enough css that there is a sidebar, the header,
and the main content area?
Yes it sounds good.
I agree it's difficult to arbitrate between what is "core" and what is
style. I would tend to think that the core skin needs to have proper
positionning, proper margins etc. and a good set of neutral defaults for
colors, fonts and the rest. Then the actual xorange CSS overrides those
defaults.
This is an area I can help you test, I actually have already started
implementing my own skin that derives xorange.
Thank you,
Jonathan Solichin
On Mon, Jul 30, 2012 at 1:09 PM, Jonathan Solichin
<j.s.solichin(a)gmail.com>wrote;wrote:
I think that's a great idea, it would make the skin more extensible.
--
Peace,
—Jerome
______________________________**_________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/ma…
Right
now I am exploring creating a xar to create a page where there can be
options-- right now for the colors, like you did with the "fluid" option
on
lyrebird.
As I am separating the codes, i am wondering how far i should separate
the
core? Should i just leave enough css that there is a sidebar, the
header,
and the main content area?
Thank you,
Jonathan Solichin
On Thu, Jul 26, 2012 at 1:42 AM, Jonathan Solichin <jssolichin(a)gmail.com
> wrote:
Hi Jerome,
> All the advise you mentioned should now be fixed on github. Ajax search
> is now implemented.
>
> I will be working on color themes, while still trying to ensure
> consistency through out XE UI.
>
> Thank you again!
> Jonathan Solichin
>
>
> On Tue, Jul 17, 2012 at 11:50 AM, Jonathan Solichin <
> jssolichin(a)gmail.com
>
>> wrote:
>> Hello Friends,
>>
>> As you may or may not know, I have been working on a responsive skin
>> for
>> XWiki for GSOC
(http://23.21.87.183:8080/**xwiki/bin/view/Main/WebHome<http://23.21.87.1…
>> ).
>> As I continue to add further details and refinements into the skin, I
>> would
>> like to kindly ask for your help in doing so. In order to make sure
>> that I
>> did not miss anything and the skin is as complete as possible, I would
>> like
>> to, if possible, request a XAR of an existing wiki (or complex pages)
>> so
>> that I may see the result of implementing the skin on more than the
>> default
>> wiki data.
>>
>> If this is not a possible, I would like to still enlist your help in
>> testing some basic/your favorite functionality/features of xwiki.
>> There are
>> several ways to do this:
>>
>> - By downloading the current skin and testing it on your XWiki:
>>
https://github.com/jssolichin/**xo5<https://github.com/jssolichin/xo5>
>> - By playing around with the live instance (uses default admin
>> user/password): http://23.21.87.183:8080/**
>>
xwiki/bin/view/Main/WebHome<http://23.21.87.183:8080/xwiki/bin/view/Main/WebHome>
>> - By letting me know of your favorite applications (so that I may
>> look into implementing them)
>>
>> Anything you want to note is fine. Bug and feature request are both
>> welcome, as I think communal ideas are often better than one. Even if
>> you
>> did not have a chance to play too much with the skin, go ahead and let
>> me
>> know what you think I should check on (based on your experience) and/or
>> give me any suggestions that may have come up while reading this.
>> Technicality permitting, I will check myself.
>>
>> Helping with this process will help make the skin better, and maybe
>> help
>> it to be tailored to your (/type of) wiki and the community
>> surrounding the
>> platform in general.
>>
>> Thank you in advance for your time!
>> Jonathan Solichin
>>
>>
> ______________________________**_________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/ma…