1 Sep
2019
1 Sep
'19
4:54 p.m.
Hi,
What I would like is a working version of the application that can be
installed, as a final version that can be linked and showed the work done.
On Sun, Sep 1, 2019 at 5:48 PM Stéphane Laurière <slauriere(a)xwiki.com>
wrote:
Hi Caty, Fawad, all,
There's been much progress on the app recently by Fawad, that's great, I
spotted a few issues that are likely to block the release indeed, not many,
most of the entries I created on Jira today are improvement suggestions for
upcoming releases. The three key ones imho are:
- JavaScript instability on map at Demo.WebHome
https://jira.xwiki.org/browse/INTMAP-76 – In case this is too long to
fix, I'd suggest we remove the indoor feature from the demo for the release
itself, so that we get a 100% working demo, what do you think? Obviously
fixing it would be even better, let me know if you need help Fawad.
- Leaflet configuration issue on installation
https://jira.xwiki.org/browse/INTMAP-74 – Removing the version number
seems to work fine with all recent XWiki versions and matches the
WebjarScriptService documentation, to be tested further, and we will need
to investigate what fails with the continuous integration, but not a
blocker issue imho.
- JSON format errors on map at Demo.WebHome
https://jira.xwiki.org/browse/INTMAP-75
Fixing the overflow issue would be nice as well since it would enhance the
first live contact of the user with the app:
https://jira.xwiki.org/browse/INTMAP-85 – Unsetting the "overflow" rule
of #xwikicontent fixes the issue but may introduce others. The Mozilla
documentation page
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow states that
"overflow" is useful only when a height is set or "white-space" set
to
"nowrap". I'm wondering in which cases the height of #xwikicontent needs
to
be set, or the "white-space" option. Do you have any idea Caty, all?
We should not remove the overflow from #xwikicontent. Make sure the map is
clearing the floats, but I find the issue to be minor.
Thanks,
Caty
Cheers
Stéphane
Fawad Ali:
Hi Ecaterina,
Hope you are well.
I was waiting for a complete review from Stephane.
There are some issues that he brought forward today. The application
will be
released as soon as those issues are resolved.
Thanks,
Fawad
On Sun, Sep 1, 2019, 6:59 PM Ecaterina Moraru (Valica) <
valicac(a)gmail.com
<mailto:valicac@gmail.com>> wrote:
Fawad, can you make sure you've released the application on Contrib?
I
don't see a new version on GitHub or on e.x.o.
Thanks,
Caty