21 Feb
2012
21 Feb
'12
11:33 p.m.
Hi Jerome,
2012/2/21 Jerome Velociter <jerome(a)winesquare.net>
Some comments :
* Using $context.setLinksQueryString("skin=${xwiki.skin}") is not
really acceptable. It breaks when you have AJAX. The skin could rather
be determined server-side based on the cookie you set.
This was not really possible, as this would need to be handled in the core
rather than in the view.vm template itself.
Note that if the link is not set, then the view.vm template will still set
it and do the redirection.
It's not so easy to find the right behavior here. Now it's true that as you
say below the changes versus colibri are not "huge" and maybe some
"if" in
colibri itself could be a great solution.
* There are some ios-specific naming
("iosdisplaypanel, div class="ios",
etc.")
Right. can be fixed easily. The macro could be moved to macros.vm also
* The UA detection could probably be improved
The UA detection would be better in the core itself
* You have some inline (onclick="blah") and
un-namespaced (see
showQuickLinks in header.vm) JS, which are respectively not respecting
web standards and our dev standards
(
http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HJavaScr…
).
ok
More than those implementation details, I wonder if
this is the right
approach. Since the differences with colibri are not very big, I
personally would prefer to see them implemented using responsive
design right in colibri.
There are some changes though, like a quite different menu bar, but it's
true that we could handle this using mostly IFs. The objective with this
implementation was to be able to run as an "skin" without too much
interaction with colibri.
What do other developer think about an implementation right in
colibri/templates directory ?
This could just be done:
- using a mobile.css which would be loaded for a set of user agents
- some "IF" to include/exclude some templates
Ludovic
Jerome
On Tue, Feb 21, 2012 at 8:30 PM, Ludovic Dubost <ludovic(a)xwiki.com> wrote:
--
Jérôme Velociter
Winesquare
http://www.winesquare.net/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
Any comments on the code ? What would need to be
done to be able to bring
this into the platform ?
Ludovic
2012/2/17 Ludovic Dubost <ludovic(a)xwiki.com>
>
> Hi,
>
> I've been working a while ago on a Mobile Skin which principle is the
> following:
>
> 1/ Light UI adapted to mobile devices, both phones and tablet (with a
> particular attention to tablets), giving most of the screen real estate
to
> the page content
> 2/ Support all Javascript normally supported in the XWiki skin in order
> for any code inside pages that would use this Javascript to still work
> 3/ Automatic detection of mobile devices to make them switch to the
mobile
> skin
> 4/ Ability to switch from mobile to normal skin
> 5/ compatibility with color themes
>
> I believe this approach is the right one, as XWiki instances do have
> significant Javascript and in order to make sure these pages work, we
need
> to be able to accept this javascript.
> Of course some other improvements could be done, for example to have a
> mobile friendly dashboard or livetable.
>
> Now this work has had a few iterations with particularly some relooking
> work from Caty.
> The work is published here:
>
> http://extensions.xwiki.org/xwiki/bin/view/Extension/SimpleMobileSkin
>
> And the code is available here in both XAR and File-System version (for
> XEM):
>
> https://github.com/ldubost/xwiki-mobileskin
>
> The skin can be tested on the incubator (although there is not the
> automated switch)
>
>
>
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/34Proposal?skin=XW…
>
> I've also worked on integrating this in the platform. The commit is
> available in a fork on github:
>
>
>
https://github.com/ldubost/xwiki-platform/commit/064baeb017b35e08a526029381…
I'd like some comments and discussion so that we can bring this into the
platform.
Ludovic
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
--
Ludovic Dubost
Founder and CEO
Blog: http://blog.ludovic.org/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs