7 Feb
2019
7 Feb
'19
3:21 p.m.
Le jeu. 7 févr. 2019 à 14:40, Eduard Moraru <enygma2002(a)gmail.com> a écrit :
+1 in general, but please consider migration issues,
specially calls to the
{{activity/}} macro that will be still found in wiki pages that will stop
working if the ActivityStream (which is a macro) is removed.
The UI of Activity Stream (which defines the macro you mentioned) is
already removed from XWiki Standard. But the retro-compatibility is handled
by
https://extensions.xwiki.org/xwiki/bin/view/Extension/Legacy%20Notification…
.
It's actually a good thing you that did not realized AS was not there
anymore :)
Also, for anyone using or extending the ActivityStream plugin's API
directly, their code will fail. I doubt there were many (if any) users of
the relatively obscure EventStream API, so the effect of the backwards
compatible "Event Stream Store" implementation will not compensate for
much, IMO.
What I am personally concerned about is that, ideally, the upgrade to the
new XWiki version (which no longer bundles these modules) require as less
(preferably none) manual operations as possible.
Thanks,
Eduard
On Wed, Feb 6, 2019 at 5:10 PM Marius Dumitru Florea <
mariusdumitru.florea(a)xwiki.com> wrote:
--
Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
+1
Thanks,
Marius
On Mon, Feb 4, 2019 at 1:50 PM Guillaume Delhumeau <
guillaume.delhumeau(a)xwiki.com> wrote:
> Dear developers,
>
> Now that we consider notifications as an achieved replacement for both
> Activity Stream and the Watchlist, I propose to stop maintaining them
and
> to move them into the "attic"
section.
>
> You need to know that we had a dependency on the Activity Stream API,
as
the only
implementation of the Event Stream, on which the Notifications
are
based. So to get rid of this dependency (the code
is not using our
component system and is not well tested), I have written a new
implementation of the Event Stream that I have called "Event Stream
Store".
It's fully backward compatible with the old
implementation, since it is
using the same Database schema. In practice, I re-used some pieces of
Activity Stream that I have modified to fit into components. For more
information, see: https://jira.xwiki.org/browse/XWIKI-16052
So my proposal is this one:
- use the new store in 11.1
- stop bundle Watchlist and AS in 11.1
- move Watchlist and AS into "attic" in 11.2
Thanks you,
--
Guillaume Delhumeau (guillaume.delhumeau(a)xwiki.com)
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project