19 Feb
2010
19 Feb
'10
6:26 p.m.
On 19/02/10 17:57, Thomas Mortagne wrote:
On Fri, Feb 19, 2010 at 17:26, Sergiu
Dumitriu<sergiu(a)xwiki.com> wrote:
I agree with Sergiu : if it is very long and has space it's OK and
should be displayed, if it is very long without spaces, the problem is
somewhere else.
Sure we can decide to trim to be on the safe side, but the limit is hard
to place (for example a title that spans over 5 lines would be OK to me,
but maybe not for someone else).
Jerome.
On 02/19/2010 03:23 PM, Thomas Mortagne wrote:
Not sure it's good to break the UI whatever the reason... On Fri, Feb 19, 2010 at 14:58, Jerome
Velociter<jerome(a)xwiki.com> wrote:
> Hi all,
>
> I propose to add a column in the document index table to display the
> document titles. Right now we only display document name and space ; and
> users do relate to the title they enter in the edit Form, not to the
> technical name of the page.
>
> Only issue is that currently we can't have this column sortable nor
> filterable since standard XE documents use the localization tool for
> their title, so searching and ordering would not provide with expected
> results.
+1. The same is already done for the deleted documents/attachments.
> I propose we add the column just after the
page name one, non
> filterable/sortable (for the moment and until we find a way to make
> internationalized titles searchable) and non clickable.
> You can check the result on the incubator wiki (just the i18n key for
> the table header is missing)
IMO, it doesn't look good between the name and the space.
* Since page title could be very big if someone did a mistake like an
{{include}} in the first header without anything in the title field
for example, we should probably protect the table by limiting the
number of chars printer with some ... when it's too long.
Not so sure about this. If it's long but with spaces, that's OK, it will
just create a fat row. If it's long without spaces (which shouldn't
happen, since it's a title; this should happen more often for the
document name, but there's a 250 chars limit on the name), then it might
overflow on small screens. If it's long because of a user error, then
it's good, at least it will be spotted, reported and fixed. * I did not tested on a 1280 screen, it could
make the table not very
nice maybe.
Looks good so far. The actions look worse than the title, we should
remove the text labels from there.
>
> Note that this will force us to add a nice title to all documents in XE
> (this is not the case right now, some technical documents in
> "blacklisted" spaces still have no title)
We could make this an integration test, similar to the orphaned pages.
> JIRA issue :
http://jira.xwiki.org/jira/browse/XE-603
>
> Opinions ?
>
> Thanks,
> Jerome.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs