1 Jan
2007
1 Jan
'07
10:36 p.m.
0
I think we need to make a more complete review of the current search APIs.
There are some security issues with sending column data in the search
results.
searchDocumentNames is an API sending back non sensitive data (only the
document names).
I believe it should be a different API sending more complex results.
I think also which should add a parameter to filter search results
according to viewer rights.
Also the HQL search API should start to be depreciated since we now have
the QueryPlugin API based on XQuery. However I've seen that the XQuery
api does not have the full capabilities of the HQL API so our API will
need to have a way to call the storage specific search API.
So maybe te right way to do it is to keep the current API for
compatibility and put the new APIs on the QueryPlugin and implement a
clean and nice search API in the QueryPlugin, including a storage
specific API.
Ludovic
Sergiu Dumitriu a écrit :
com.xpn.xwiki.store.XWikiHibernateStore.searchDocumentsNames supports
a selectColumns parameter which is supposed to specify which columns
should be selected.
This parameter is used when building the select string, but the
columns are not included in the returned list, so this parameter just
makes a bigger select string and increases the execution time.
In order to include the specified columns in the result, I propose this:
- if selectedColumns is the empty string, keep the previous behavior
(return a list of document names)
- if selectedColumns is not empty, then return a list of hashmaps,
with the column name as the key, with a special name for the document
name (for example docname)
------------------------------------------------------------------------
--
You receive this message as a subscriber of the xwiki-dev(a)objectweb.org mailing list.
To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org
For general help: mailto:sympa@objectweb.org?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
--
Ludovic Dubost
Blog: http://www.ludovic.org/blog/
XWiki: http://www.xwiki.com
Skype: ldubost GTalk: ldubost
AIM: nvludo Yahoo: ludovic