9 May
2018
9 May
'18
4:14 p.m.
On 9 May 2018, at 16:00, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
On Wed, May 9, 2018 at 3:53 PM, Vincent Massol <vincent(a)massol.net> wrote:
Ok I understand now what you mean. Indeed we could have had another page for holding the
ConfigurableClass and thus separate the UI aspects from the data aspects.
Thanks
-Vincent
Hi,
MailConfig is the entry point used by admin UI to get the UI related
to mail configuration (indicated by several XWiki.ConfigurableClass
objects) so it is a UI element itself. On 9 May 2018, at 15:46, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
Hi xwikiers,
Denis expressed to me some concerns about the type that should be
associated to Mail.MailConfig since it contains configuration data.
One important issue I see if that this page is primarily an admin
configuration UI
I don’t understand this sentence. MailConfig is not an UI and it doesn’t contain
configuration for UI. It contains config for the mail server, mail properties, etc. It
contains mail configuration data. Not related to UI. which happen to also contains configuration data
(would have been much cleaner to store the data in a generated
document…)
Same, could you explain this more?
so I think the best for now is to keep the
default type.
Since you are not supposed to go trough edit more to modify those
configuration data, the edit protection should not really affect users
in practice (no warning when using admin UI).
We happen to have some Admin UI that changes the MailConfig page so I’m fine to use
‘default’ (i.e. to warn the users when they try to edit it).
The important aspect is that we don’t try to merge it when the admin upgrades the wiki
and there’s been changes brought to it (through the Admin UI), and I believe “default”
will achieve this.
Now we might have other *Config pages for which we’re currently lacking an Admin UI till
we provide such a UI, we’ll need to mark those as “demo” for now.
So ok for me for MailConfig (if I understood correctly).
Thanks
-Vincent
WDYT ?
--
Thomas Mortagne