2007/8/8, Vincent Massol <vincent(a)massol.net>et>:
We need to decide if we postpone the release for this.
IMO this is
very important and required new feature so I'm +1 to postpone the
release to Friday (I need 1 full day, Friday to perform the release)
in order to get this in. In addition this will allow me to work on
fixing the code macro issue and we should use the remaining time to
ensure the big changes brought by the history table haven't broken
anything.
What do others think?
+1
I suggest the following:
1) We add a new method in XWiki.java (sigh, it'll just be bigger)
called getWorkDirectory(). It'll be used by all code that require
some work/tmp directories.
2) That method does the following:
a) it checks if the work directory is specified in xwiki.cfg file
(say with a xwiki.work.dir property)
b) if not, then the javax.servlet.context.tempdir attribute of the
web application is checked to see if a directory name or a File has
already been set.
c) if a WEB-INF/work directory exists, it is used directly.
d) If a <current dir>/work directory exists, then a temp directory is
created within that directory.
e) if no other location has been found, a temporary directory is
created within the ${java.io.tmpdir} directory.
I'm +1 (note : with 5 plugins currently using
javax.servlet.context.tempdir it'd mean some refactoring).
b) do we make
the lucene search the default one ?
Unless there are issues with it, I'd say yes.
That information box looks like the lucene search isn't working well.
I'm fine with putting a message but we need to mention that the
lucene search has been recently added and is still under observation
for any issue, or something like that and that once the observation
period is over it'll be removed.
What I had in mind was a similar box but not with that text :)
We probably need to explain too in that box that the
lucene search is
now searching inside attachements for PDF, Word, Excel, etc. and that
the indexing is done in a different thread is no longer synchronous
with changes (default delay of 20 seconds controlled by such parameter).
good idea.