4 Jun
2008
4 Jun
'08
9:24 a.m.
I remember why it was 98 and not 100 below for Eclipse. That's because
with 100 sometimes it failed to cut the line at 100 and went beyond it.
Let's see what it does now.
Thanks
-Vincent
On Jun 4, 2008, at 4:32 AM, sdumitriu (SVN) wrote:
Author: sdumitriu
Date: 2008-06-04 04:32:10 +0200 (Wed, 04 Jun 2008)
New Revision: 10097
Modified:
xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/src/
main/resources/checkstyle.xml
xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/src/
main/resources/codestyle-eclipse.xml
xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/src/
main/resources/codestyle-idea.xml
Log:
XTVERIFICATIONS-3: Increase the maximum line length in java source
files to 120
Done.
Modified: xwiki-platform/xwiki-tools/trunk/xwiki-verification-
resources/src/main/resources/checkstyle.xml
===================================================================
--- xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/checkstyle.xml 2008-06-04 01:27:17 UTC (rev 10096)
+++ xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/checkstyle.xml 2008-06-04 02:32:10 UTC (rev 10097)
@@ -200,8 +200,8 @@
</module>
<module name="LineLength">
- <property name="ignorePattern" value="(@version|@see|
^import)"/>
- <property name="max" value="100"/>
+ <property name="ignorePattern" value="(@version|@see|@link|
^import)"/>
+ <property name="max" value="120"/>
</module>
<module name="LocalFinalVariableName"/>
Modified: xwiki-platform/xwiki-tools/trunk/xwiki-verification-
resources/src/main/resources/codestyle-eclipse.xml
===================================================================
--- xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/codestyle-eclipse.xml 2008-06-04 01:27:17 UTC
(rev 10096)
+++ xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/codestyle-eclipse.xml 2008-06-04 02:32:10 UTC
(rev 10097)
@@ -70,7 +70,7 @@
<setting
id
=
"org
.eclipse
.jdt
.core
.formatter
.insert_space_before_opening_angle_bracket_in_type_parameters"
value="do not insert"/>
<setting
id
=
"org
.eclipse
.jdt.core.formatter.insert_new_line_in_empty_type_declaration"
value="insert"/>
<setting
id
=
"org
.eclipse
.jdt.core.formatter.comment.clear_blank_lines_in_block_comment"
value="true"/>
-<setting id="org.eclipse.jdt.core.formatter.lineSplit"
value="98"/>
+<setting id="org.eclipse.jdt.core.formatter.lineSplit"
value="120"/>
<setting
id
=
"org
.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_if"
value="insert"/>
<setting
id
=
"org
.eclipse
.jdt
.core
.formatter.insert_space_between_brackets_in_array_type_reference"
value="do not insert"/>
<setting
id
=
"org
.eclipse
.jdt
.core
.formatter
.insert_space_after_opening_paren_in_parenthesized_expression"
value="do not insert"/>
@@ -184,7 +184,7 @@
<setting
id
=
"org
.eclipse
.jdt.core.formatter.insert_new_line_before_while_in_do_statement"
value="do not insert"/>
<setting
id
=
"org
.eclipse
.jdt.core.formatter.alignment_for_arguments_in_enum_constant"
value="20"/>
<setting
id="org.eclipse.jdt.core.formatter.comment.format_javadoc_comments"
value="true"/>
-<setting id="org.eclipse.jdt.core.formatter.comment.line_length"
value="100"/>
+<setting id="org.eclipse.jdt.core.formatter.comment.line_length"
value="120"/>
<setting
id
="org.eclipse.jdt.core.formatter.blank_lines_between_import_groups"
value="1"/>
<setting
id
=
"org
.eclipse
.jdt
.core
.formatter.insert_space_before_comma_in_enum_constant_arguments"
value="do not insert"/>
<setting
id="org.eclipse.jdt.core.formatter.insert_space_before_semicolon"
value="do not insert"/>
Modified: xwiki-platform/xwiki-tools/trunk/xwiki-verification-
resources/src/main/resources/codestyle-idea.xml
===================================================================
--- xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/codestyle-idea.xml 2008-06-04 01:27:17 UTC (rev
10096)
+++ xwiki-platform/xwiki-tools/trunk/xwiki-verification-resources/
src/main/resources/codestyle-idea.xml 2008-06-04 02:32:10 UTC (rev
10097)
@@ -34,7 +34,7 @@
<option name="BLANK_LINES_AROUND_FIELD" value="1" />
<option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="99"
/>
<option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="99"
/>
- <option name="RIGHT_MARGIN" value="100" />
+ <option name="RIGHT_MARGIN" value="120" />
<option name="CALL_PARAMETERS_WRAP" value="1" />
<option name="METHOD_PARAMETERS_WRAP" value="1" />
<option name="EXTENDS_LIST_WRAP" value="1" />