On Wed, Sep 14, 2016 at 9:36 AM, Vincent Massol <vincent(a)massol.net> wrote:
On 14 Sep 2016, at 09:27, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
On Wed, Sep 14, 2016 at 8:29 AM, Vincent Massol <vincent(a)massol.net> wrote:
On 14 Sep 2016, at 07:58, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
[snip]
> We have a pretty good definition of core
already:
> - All modules that make up the base distribution.
> - Modules maintained and developed by the XWiki Core Deve team (i.e. located in a
repo in the XWiki organization on github)
About that, you did not answered my comment on the fact that you plan
to put "Knownledge Base" flavor (which will depends on various Contrib
extensions) in xwiki-platform.
Sorry I must have missed it. You have a markmail link to your comment so I can see the
context?
http://markmail.org/message/ebcsjq6klye4oxn4
Thanks
For me it’s not a major problem to have a flavor inside platform that depends on contrib
stuff. We’re already doing this with xwiki-enterprise and the KB flavor is the same as
xwiki-enterprise (moved to xwiki-platform).
I was just pointing out that you just defined core extensions as
extensions being "located in a repo in the XWiki organization on
github”.
Actually I wanted to say that it has to meet 2 criteria but I probably wasn’t clear that
it was an “AND” and not an “OR”:
“
We have a pretty good definition of core already:
- All modules that make up the base distribution.
- Modules maintained and developed by the XWiki Core Deve team (i.e. located in a repo in
the XWiki organization on github)
“
So the KB flavor doesn’t meet this definition (since it’s not in the base distribution).
But anyway, let’s continue the discussion based on my answer where I listed some
pros/cons that I see.
I’m curious to see what you guys think and whether you think moving the KB flavor to
xwiki-contrib is what we should do.
Thanks
-Vincent
> Having KB in xwiki-platform is just a way to clearly show that this flavor is
maintained by the XWiki Core dev team. And to be able to maintain its quality since this
is the main flavor that people will use.
>>
>> Actually I wouldn’t mind either if we wanted to move it out of the xwiki github
org and put in xwik-contrib.
>>
>> Cons:
>> - a bit less control on its quality
>> - additional release work for the Release Manager. We need to at least release it
at the same time as we release new versions of the base distribution so that our users
have something they can use.
>> - we might need to separate the RN for the base distribution from the RN for the
KB flavor (since the KB flavor can have more releases and it would no longer be “core”).
>> - the xwiki github org doesn’t deliver any
immediately usable distribution.
This is a bit misleading. What most people will download is the XWiki
distribution on which you can select a flavor like "Knowledge Base" in
the DW.
>>
>> Pros:
>> - ability to release the KB flavor more often than the base distribution
We discussed about speed up the release cycle of platform anyway.
>> - ability to let other member of the community
contribute more easily to it
I'm not so sure about this plus a flavor is quite close to an empty
shell anyway so there is not much to contribute to in practice.
>> - we no longer have any contrib dependency
inside the XWiki github organization
>>
>> The pros are tempting :)
>>
>> WDYT?
IMO it's way too much work and too error prone to not sync with
xwiki-platform release cycle what is going to be the XWiki Dev Team
supported recommended default flavor.
We just need to be more clear about the dependencies rules in xwiki
organization and probably stop fighting over what "core" term means.
For example we could simply say:
* XWiki WAR and "Base Flavor" are not allowed to trigger any
xwiki-contrib dependency
* Like most flavors "Knownledge Base" flavor depends on "Base Flavor"
and any other thing that make sense for its purpose
* Since we want to make "Knownledge Base" flavor in sync with platform
for now we keep it in platform (probably in its own top level
xwiki-platform/xwiki-platform-knownledgebase folder) because it's a
lot easier and safer like this. Maybe later we'll decide to give
"Knownledge Base" its own life in Contrib (when there will be various
good quality flavors in there probably) but we don't need to worry
much that for now.
>
> Thanks
> -Vincent
>
> [snip]
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne