8 Jun
2005
8 Jun
'05
4:38 a.m.
Hello,
Ludovic Dubost wrote:
Hi Lilianne,
Sorry for the late response and thanks for this patch ! We love
improvements to XWiki !
First I think we should go through Jira to submit patches. I've create
a task at:
http://jira.xwiki.org/jira/browse/XWIKI-36
You should subscribe and join in on this task. If you can add the
patches as attachment in this task it would be great.
Ok, I'll try to do it later today or tomorrow.
Concerning the code, the main remark I have would be to put it in the
com.xpn.xwiki.web.includeservlet package, since it is not specific to
Velocity but adds a feature to the XWiki API.
Are you sure? The code is not dependent on Velocity, but it is a
solution to Velocity-specific problem? Without Velocity a standard
RequestDispatcher would completely suffice.
Finally, it would be great if you could add a TestCase
which
demonstrates the features and verifies that it works fine. You will
probably need to add the test to ViewEditTest which means it involves
a TomCat local install to make it run.
Is it necessary? Honestly, I'm not a big fan of high or medium -level
TestCases, and I'm just not sure how to write it to fit it in existing
XWiki test code.
You haven't said anything about the second patch ("A small patch for
XWiki.getAuthService and XWiki.getRightService (easier debugging mostly)")?
Ludovic
Greetings, Lilianne E. Blaze