25 Mar
2015
25 Mar
'15
3:41 p.m.
BTW and FYI the following:
{{groovy}}
class MyClass {}
{{/groovy}}
{{groovy}}
def var = new MyClass()
{{/groovy}}
Returns:
MyClass
MyClass@5519a693
Note: the reason for "MyClass@5519a693” is because we don’t have a converter from
MyClass to String. We could improve my change to not display anything if there’s no
converter available if we wanted but I’m not sure it’s the best thing to do.
Thanks
-Vincent
On 25 Mar 2015 at 15:10:21, vincent(a)massol.net
(vincent@massol.net(mailto:vincent@massol.net)) wrote:
Hi devs,
I’ve implemented http://jira.xwiki.org/browse/XWIKI-11961
However it’s causing several tests to fail, proving that it’s changing the script
behaviors. For example if you have:
{{groovy}}
var = "toto"
{{/groovy}}
{{velocity}}
$var
{{/velocity}}
Then you’ll see “toto” printed twice. Once for the groovy macro.
The right way to not output content is to use output=false as in:
{{groovy output="false"}}
var = "toto"
{{/groovy}}
{{velocity}}
$var
{{/velocity}}
So we need to decide if we’re ok to go with this even though it changes the behavior.
I don’t completely master the full gamut of consequences this will have but I have the
feeling that from a logical point of view, it’s the best thing to have.
WDYT?
Thanks
-Vincent