On Thu, Sep 25, 2014 at 3:00 PM, Thomas Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
On Thu, Sep 25, 2014 at 1:40 PM, Marius Dumitru
Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
On Thu, Sep 25, 2014 at 12:51 PM, Thomas
Mortagne
<thomas.mortagne(a)xwiki.com> wrote:
This is not really related to this issue. I'm
not talking about
something you can't do anymore, I'm talking about ways to do it.
What is important here is to have the same
structure as what you
override, as long as you put English in the default version of the
document (like it's the default in ApplicationResources.properties)
and French as translation you will just override what you need to
override. When current locale is french it will not even look at the
default version of the document because it will find a translation in
ApplicationResources.fr.properties first.
This makes sense so I don't see any problem with the new behaviour.
I never said the new behavior is wrong, I like the new behavior :)
Just saying it can break retro-ompatibility in some (crappy IMO) use
cases and just asking if we should try to hack something about it for
XWikiPreference based translations or not.
Thanks,
Marius
On Thu, Sep 25, 2014 at 11:25 AM, Marius Dumitru Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
On Thu, Sep 25, 2014 at 12:24 PM, Marius Dumitru
Florea
<mariusdumitru.florea(a)xwiki.com> wrote:
> So if I have two different keys, key1 and key2, defined in
> ApplicationResources.properties can I overwrite the French value for
> key1 and the English (default) value of key2 from the same document
> translation bundle (using the French and English translations of that
> bundle)?
Without overwriting the English value for key1 and the French value for key2.
>
> Thanks,
> Marius
>
> On Wed, Sep 24, 2014 at 3:58 PM, Thomas Mortagne
> <thomas.mortagne(a)xwiki.com> wrote:
>> Hi devs,
>>
>> I just created
http://jira.xwiki.org/browse/XWIKI-11108.
>>
>> You have all the details in the issue but basically there is a
>> difference between old and new localization systems behaviors with
>> document based translation bundles that can lead to translations being
>> broken after an upgrade in the following use case:
>>
>> * default version of the document contain French override of some standard key
>> * a translation of the document is "en" and empty
>>
>> When current locale is "en":
>> * before 4.3 you get default translation from the
>> ApplicationResources.properties
>> * after 4.3 you get the French override from the document because this
>> is the default translation and documents have priority over resources.
>>
>> Do we need to do something about it ?
>>
>> Overriding standard translation with a totally inconsistent document
>> translation was not very clean in the first place IMO and I'm not sure
>> it really worth it (supporting it in the current architecture would
>> probably mean breaking some API).
>>
>> --
>> Thomas Mortagne
>> _______________________________________________
>> devs mailing list
>> devs(a)xwiki.org
>>
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
--
Thomas Mortagne
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs