7 Jul
2017
7 Jul
'17
1:11 p.m.
On 6 Jul 2017, at 19:09, deshengchuan
<chuandesheng54(a)gmail.com> wrote:
Ok so it’s hardcoded and thus static ATM.
A simple solution is simply to introduce a configuration API in the CheckerConfiguration
interface:
Map<String, SeverityLevel> getSeverityLevels()
Note that in xwiki.properties it’ll be defined as:
redpen.severityLevels = SuccessiveWord = warning
redpen.severityLevels = DoubleNegative = error
…
Sounds good for now. How do you configure if a
check is a warning or an
error?
I'm using a primitive way now actually. I just retrieve the type of
validator from the error (which is in string), check it against an array of
validators that are errors. Relevant code snippets are here:
https://pastebin.com/4HQukUzU <http://https://pastebin.com/4HQukUzU> . I
would appreciate any suggestions to make this code more elegant. Also, is it possible to try the application right
now? Can I build it and
install it in my wiki? Is it going to work?
I am really sorry for delaying this, but it was working a couple days back
until I added another bunch of code into it. I will get it working before
this weekend. Not quite clear what you mean. A mockup or
screenshot on the design page
would be great.
I will make mockup and screenshots asap. Meanwhile, my current application
homepage still remains unchanged, accessible at
http://http://design.xwiki.org/xwiki/bin/download/Proposal/RedPenIntegratio…
<http://http://design.xwiki.org/xwiki/bin/download/Proposal/RedPenIntegration/App_home.PNG>
. 
You’ve use AWM to create the app? If so you
should instead use the manual
way as for the FAQ app tutorial here:
Yeah I actually used AWM. Will use the manual way to create it.
I haven’t checked the code yet after my comments
(I think there are still
some comments I’ve mentioned that don’t have an answer; I remember asking
you for an example of a setting since I believe a List is not the right
format).
Oops I must have missed them out. Sorry about that! I replied your latest
github comment; I am unclear towards the nature of the example (do you
request a code, screenshot etc)
Just checked the maven build and found several
issues that I’ve fixed.
Also noticed there’s no functional tests at all.
Ok will work on the functional tests asap as well. Thank you for the
guidance and the fixes, appreciate it very much :)
--
View this message in context:
http://xwiki.475771.n2.nabble.com/GSOC-Update-4-Design-RedPen-Integration-t…
Sent from the XWiki- Dev mailing list archive at Nabble.com.