14 Jul
2009
14 Jul
'09
8:02 a.m.
Vincent Massol wrote:
On Jul 13, 2009, at 11:25 PM, Anca Paula Luca wrote:
Yes, but you can manually split a long line in multiple lines by using
additional variables to store intermediate results and using a
StringBuffer to concatenate strings. IMO if the code formatter fails to
give the optimal result then you should adjust your code.
Manual formatting can leave a lot of white spaces (especially at the end
of lines) which the code formatter can easily fix.
Thanks,
Marius
Sergiu Dumitriu wrote:
codestyle files are always suboptimal since editors don't support all
possible code styles. For ex the eclipse one is wrong in several
instances (the IDEA one was better since IDEA supported more options
in the past).
In any case you cannot get perfect code styles with any IDE. (This is
btw why I always format manually as I type). Vincent Massol wrote:
I agree with Sergiu here, maybe, if automatic is
suboptimal, we need
to revisit
our codestyle files. It's quite difficult to only format pieces of a
file (one's
changes), and it often results in forgetting to do it. Hi Thomas,
On Jul 13, 2009, at 3:20 PM, tmortagne (SVN) wrote:
> Author: tmortagne
> Date: 2009-07-13 15:20:03 +0200 (Mon, 13 Jul 2009)
> New Revision: 21910
>
General comments:
- Would be great if you could separate code reformatting from code
changes. It makes it hard to read (I didn't read the commit fully
as a
consequence).
+10
- The code style has broken my styles in lots of
places (see below
for
some comments, I haven't commented every single place it broke
voluntary formatting).
I'd like to vote for not applying code style blindly in the
future. It
breaks styles in lots of places and I hate it when I spend a good
amount of my time to align code properly and it breaks it for
producing suboptimal styling...
There are two things to balance here:
- forgetting to format the code manually
- suboptimal formatting done automatically
I for one prefer to have more codestyle-compliant code than less, and
automatic application does this.
All I'm asking is that people stop blindly reformatting other people's
code. This means that you're allowed to use automatic reformatting but
you must check thereafter that no weirdies were introduced and
manually fix introduced "errors".
To see the kind of "errors" I'm talking about see my specific comments
to thomas' commit.
Thanks
-Vincent
Happy coding,
Anca
> The way I do commits is:
>
> - change the code
> - check what would the commit look like (using git diff)
> - if I detect something wrong in the codestyle, I selectively accept
> changes in the commit, using git add --interactive, which allows me
> to
> choose which files to commit, and even inside a file, which changes
> - final check on the prepared commit using git diff --cached
>
> This process takes a while, but it ensures high quality commits.
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs