Re: [xwiki-devs] [proposal] Make private and remove deprecated and internal/unused functions in XWikiHibernateStore

According to my records (fool I was I didn't use @since) r30719 [misc.] Deprecated XWikiHibernateStore functions which should be internal. was prior to 2.5M1 which means that they have been deprecated for 2.5, 2.6, and 2.7. The original mail: http://lists.xwiki.org/pipermail/devs/2010-August/019620.html I propose removing: saveXWikiClassProperty  used nowhere. deleteXWikiClass  used nowhere. getBatcherStats  used nowhere. resetBatcherStats  used nowhere. and making private: loadXWikiProperty  used nowhere (outside of XWikiHibernateStore). saveXWikiClass  used nowhere (outside of XWikiHibernateStore). loadXWikiClass  used nowhere (outside of XWikiHibernateStore). loadAttachmentList  used nowhere (outside of XWikiHibernateStore). saveAttachmentList  used nowhere (outside of XWikiHibernateStore). saveAttachment  used nowhere (outside of XWikiHibernateStore). injectCustomMappingsInSessionFactory  used nowhere (outside of XWikiHibernateStore). injectInSessionFactory  used nowhere (outside of XWikiHibernateStore). isValidCustomMapping  used nowhere (outside of XWikiHibernateStore). Others may be made private or removed as dependencies in the platform are retired or refactored. WDYT? Caleb _______________________________________________ devs mailing list devs(a)xwiki.org http://lists.xwiki.org/mailman/listinfo/devs