Re: [xwiki-devs] Problems accessing DocumentAccessBridge from the XWiki implementation for Shindig PersonService

Hi, I extended one of the servlets (JsonRpcServlet [0]) handling the Shindig calls (/social/rpc/*) just for testing. The new servlet is called XWikiShindigServlet (see complete class code at the bottom). XWikiShindigServlet initializes the XWiki Context and container components similar to XWiki GWT and REST services. (see class code at bottom) Should this be enough or the resulted context has to be passed further along from call to call until reaches PersonServiceXW [1] ? And, in PersonServiceXW can I still use @Requirement DocumentAccessBridge to access the component, or do I have to use the XWiki context like in XWikiServiceImpl [2], with calls like, for example: XWikiDocument doc = context.getWiki().getDocument(fullName, context); Note: there are about other 7 servlets in Shindig, some of them use a GadgetContext [3] object as context. I didn't look closely to all of them how they work. The approximate inverted call stack I'm looking at looks like this: org.xwiki.opensocial.social.XWikiShindigServlet.doPost(HttpServletRequest, HttpServletResponse) org.apache.shindig.protocol.JsonRpcServlet.doPost(HttpServletRequest, HttpServletResponse) org.apache.shindig.protocol.JsonRpcServlet.dispatchBatch(JSONArray, Map<String, FormDataItem>, HttpServletRequest, HttpServletResponse, SecurityToken) org.apache.shindig.protocol.JsonRpcServlet.getHandler(JSONObject, HttpServletRequest) org.apache.shindig.protocol.DefaultHandlerRegistry.getRpcHandler(JSONObject) org.apache.shindig.protocol.DefaultHandlerRegistry.RpcInvocationWrapper.execute(Map<String, FormDataItem>, SecurityToken, BeanConverter) org.apache.shindig.protocol.DefaultHandlerRegistry.RpcInvocationHandler.execute(JSONObject, Map<String, FormDataItem>, SecurityToken, BeanConverter) org.apache.shindig.social.opensocial.service.PersonHandler.get(SocialRequestItem) org.xwiki.opensocial.social.spi.internal.PersonServiceXW.getPerson(UserId, Set<String>, SecurityToken) [0] - https://svn.apache.org/repos/asf/incubator/shindig/trunk/java/common/src/ma… [1] - https://svn.xwiki.org/svnroot/xwiki/sandbox/gsoc/opensocial/xwiki-social-op… [2] - http://svn.xwiki.org/svnroot/xwiki/platform/web/trunk/gwt/src/main/java/com… [3] - http://svn.apache.org/repos/asf/incubator/shindig/trunk/java/gadgets/src/ma… public class XWikiShindigServlet extends JsonRpcServlet { private XWikiContext context; @Override protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException { try { this.context = initializeXWikiContext(req, resp); super.doGet(req, resp); } finally { if (context != null) { cleanupContainerComponents(); } } } @Override protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException { try { this.context = initializeXWikiContext(req, resp); super.doPost(req, resp); } finally { if (context != null) { cleanupContainerComponents(); } } } private XWikiContext initializeXWikiContext(HttpServletRequest req, HttpServletResponse resp) throws XWikiException, ServletException { XWikiEngineContext engine = new XWikiServletContext(getServletContext()); XWikiRequest request = new XWikiServletRequest(req); XWikiResponse response = new XWikiServletResponse(resp); XWikiContext context = Utils.prepareContext("", request, response, engine); // Initialize the Container component which is the new way of transporting the Context in the new // component architecture. initializeContainerComponent(context); return context; } private void initializeContainerComponent(XWikiContext context) throws ServletException { // Initialize the Container fields (request, response, session). // Note that this is a bridge between the old core and the component architecture. // In the new component architecture we use ThreadLocal to transport the request, // response and session to components which require them. ServletContainerInitializer containerInitializer = (ServletContainerInitializer) Utils.getComponent(ServletContainerInitializer.class); try { containerInitializer.initializeRequest(context.getRequest().getHttpServletRequest(), context); containerInitializer.initializeResponse(context.getResponse().getHttpServletResponse()); containerInitializer.initializeSession(context.getRequest().getHttpServletRequest()); } catch (ServletContainerException e) { throw new ServletException("Failed to initialize request/response or session", e); } } private void cleanupContainerComponents() { Container container = (Container) Utils.getComponent(Container.class); Execution execution = (Execution) Utils.getComponent(Execution.class); // We must ensure we clean the ThreadLocal variables located in the Container and Execution // components as otherwise we will have a potential memory leak. container.removeRequest(); container.removeResponse(); container.removeSession(); execution.removeContext(); } } Thanks, Anamaria On Mon, Aug 10, 2009 at 4:28 PM, Anamaria Stoica &lt;anam.stoica(a)gmail.com&gt;wrote;wrote: