Re: [xwiki-devs] [Proposal] Introduce 2 new loggers "org.xwiki.initialization" and "org.xwiki.shutdown"

On Wed, Sep 24, 2014 at 3:07 PM, vincent(a)massol.net wrote: Not all that is about XWiki shutting down, each time you delete a wiki ECM#dispose() is called to dispose the CM associated to that wiki.

> For the “org.xwiki.initialization” one I don’t know yet, I haven’t done it. Basically at places where important subsystems are initialized. Some ideas: > > - InitializableLifecycleHandler > - SOLR init (maybe not needed if done through Initializable) > - EM init (maybe not needed if done through Initializable) > - ... > > Thanks > -Vincent > >> On Wed, Sep 24, 2014 at 2:06 PM, vincent(a)massol.net wrote: >> > Hi Devs, >> > >> > I’d like to add some logging to debug what happens when XWiki shuts down. >> > >> > One solution would be to just use the standard class loggers with LOGGER.debug(…). >> > >> > However this means activating debug logging for everything and thus you cannot just focus on the shutdown part. >> > >> > WDYT about adding 2 new loggers "org.xwiki.initialization" and “org.xwiki.shutdown”? >> > >> > Example usage: >> > >> > /** >> > * Logger to use to log shutdown information. >> > */ >> > private static final Logger SHUTDOWN_LOGGER = LoggerFactory.getLogger("org.xwiki.shutdown"); >> > >> > ... >> > >> > SHUTDOWN_LOGGER.debug("Stopping component [{}]...", instance.getClass().getName()); >> > ... >> > SHUTDOWN_LOGGER.debug("Component [{}] has been stopped", instance.getClass().getName()); >> > >> > Then it becomes easy to set, in logback.xml: >> > >> > >> > >> > A small variation would be to use SHUTDOWN_LOGGER.info() and in logback.xml, by default to have: >> > >> > >> > >> > Note that this would be the first time we use non-class loggers which is why I’m asking for your go-ahead. >> > >> > Thanks >> > -Vincent