14 Feb
2014
14 Feb
'14
3:15 p.m.
Hi Clemens,
On 14 Feb 2014 at 14:58:33, Clemens Klein-Robbenhaar
(c.robbenhaar@espresto.com(mailto:c.robbenhaar@espresto.com)) wrote:
Normally there aren’t any since we normally fail the build in the webstandards functional
tests when they happen.
Do you have any in mind? :)
Hi devs,
I’d like to propose a Deprecation Fixing Day for the next XWiki Day, ie for the 20 Feb
2014.
The rules I propose:
* On that day, I send the reminder email with inside the # of deprecated calls found in
Commons, Rendering and Platform. For example right now it’s:
- Commons: 39
(http://sonar.xwiki.org/drilldown/issues/1?&rule=squid%3ACallToDeprecate…)
- Rendering: 3
(http://sonar.xwiki.org/drilldown/issues/915?&rule=squid%3ACallToDepreca…)
- Platform: (still being computed, I don’t have a link to give ATM ;))
* One goal is to replace calls to deprecated methods by new API calls
* Another goal is to move deprecated methods and types to legacy modules
* On that day, I'll prepare a Blog post on xwiki.org (not published) and everyone who
participates to this day should edit the blog post with his score for the day (since it’s
hard to compute automatically). There’ll be 2 scores for everyone: a score for removed
deprecated calls (1 point per removal) and a score for types and methods moved to legacy
modules (1 point per type and method moved).
WDYT?
Good idea. Do deprecated calls in Wiki documents serialised as *.xml also count? I worry a bit about how to avoid two people fixing the
same calls concurrently.
Formally one might be able to achieve this by this workflow:
- before you start on one point, edit the said Blog post, but score yourself 0 points for
the change you want to do
(only after checking that nobody else already did so, of course)
- fix the problem
- afterwards add the correct score to yourself
However I guess that is just too much red tape, and dropping a line in chat is good
enough to coordinate ?
Yes IMO using IRC to coordinate is good enough.
Alternatively we could decide to create jira issues with component being “Development
issue only” (this component already exists).
Thanks
-Vincent
Cheers,
Clemens
> Note that in the future I’d like to expand this to a more generic Violation Fixing
Day which would be about fixing any type of violations as reported by Sonar but before we
do this we need to decide which violations we consider important and configuration Sonar
properly for that. I’ll try to propose something on this soon.
>
> Thanks
> -Vincent