[xwiki-devs] JavaScript dependency... git-module and maven?

Hello fellow developers, At Curriki we are about to take over a new JS library for some assessment specific pages. The library is a GitHub repository which we would like to fork and include in Curriki's webapp. Our intent is to do the following but I would like to know if there is a danger of doing so or if it is indeed best practice. - we fork the GitHub repository - part of the adaptation includes creating a maven project; it would build a (partial) web-application - Curriki's web project depends on that webapp(-part) and thus includes the resources - so as to ensure that recipients of Curriki can also build with it, we make the repository a sub-module (somewhat equivalent to an svn:external) in Git and in maven Thanks in advance for your comments, hints as to possible advantages or dangers. Paul