On Thu, Jan 30, 2014 at 2:06 PM, vincent(a)massol.net <vincent(a)massol.net> wrote:
Hi devs,
I'd like to propose removing the feature of extracting the title from the content in
6.x.
The rationale is:
* This is costing more than it should. It needs parsing the document content to get its
XDOM and then to traverse it to find Heading blocks. When we display doc titles in lists
(in livetables for example or in the activity stream) it costs a lot to do so.
* Our implementation is broken since if you use an include macro that generates a heading
for ex, it won't be taken into account since we don't apply transformations ATM
when computing the title since it would be even more expensive.
Since 6.x is about performance I believe this would be a good step forward.
Now in order to handle backward compatibility. I propose that we:
* Add a legacy configuration parameter to keep the behavior (but off by default). This
would be in order to let users using this feature convert their wiki
We could reuse xwiki.title.compatibility for that too maybe.
* Move the code to a legacy module (I hope it's
possible)
Here's my +1
Thanks
-Vincent
_______________________________________________
devs mailing list
devs(a)xwiki.org
http://lists.xwiki.org/mailman/listinfo/devs
Big plus 1, I always been against keeping this xwiki/1.0 hack. We also
need to put xwiki.title.compatibility back to disabled by default (it
was initially disabled and then enabled supposedly temporary for wrong
reasons).
--
Thomas Mortagne